Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 16019014: Remove "Search" suffix from omnibox search engine match (Closed)

Created:
7 years, 7 months ago by Aaron Jacobs
Modified:
7 years, 6 months ago
CC:
chromium-reviews, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove "Search" suffix from omnibox search engine match Example (new on top, old on bottom): http://imgur.com/a/vx7pW BUG=99426 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203052

Patch Set 1 #

Patch Set 2 : Restrict removal to extension keywords #

Total comments: 2

Patch Set 3 : Peter's requests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M chrome/browser/autocomplete/autocomplete_controller.cc View 1 2 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Aaron Jacobs
7 years, 7 months ago (2013-05-24 21:46:47 UTC) #1
Devlin
lgtm
7 years, 6 months ago (2013-05-28 20:12:29 UTC) #2
Aaron Jacobs
Peter: Owners for chrome/browser/autocomplete/autocomplete_controller.cc
7 years, 6 months ago (2013-05-29 20:22:04 UTC) #3
Peter Kasting
LGTM https://codereview.chromium.org/16019014/diff/2001/chrome/browser/autocomplete/autocomplete_controller.cc File chrome/browser/autocomplete/autocomplete_controller.cc (right): https://codereview.chromium.org/16019014/diff/2001/chrome/browser/autocomplete/autocomplete_controller.cc#newcode564 chrome/browser/autocomplete/autocomplete_controller.cc:564: // Don't add the "Search" suffix for extension ...
7 years, 6 months ago (2013-05-29 21:07:20 UTC) #4
Aaron Jacobs
https://codereview.chromium.org/16019014/diff/2001/chrome/browser/autocomplete/autocomplete_controller.cc File chrome/browser/autocomplete/autocomplete_controller.cc (right): https://codereview.chromium.org/16019014/diff/2001/chrome/browser/autocomplete/autocomplete_controller.cc#newcode564 chrome/browser/autocomplete/autocomplete_controller.cc:564: // Don't add the "Search" suffix for extension keywords. ...
7 years, 6 months ago (2013-05-29 21:27:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Samusaaron3@gmail.com/16019014/9001
7 years, 6 months ago (2013-05-29 21:27:43 UTC) #6
commit-bot: I haz the power
7 years, 6 months ago (2013-05-30 03:57:18 UTC) #7
Message was sent while issue was closed.
Change committed as 203052

Powered by Google App Engine
This is Rietveld 408576698