GTK Themes: A gtkrc file can now override our choice of frame color by

GTK Themes: A gtkrc file can now override our choice of frame color by
specifying "frame_color" and "inactive_frame_color" in the gtk_color_scheme.

Also attempts to do a better job matching the frame color. Most window
managers (defined as metacity default theme and xfwm's default theme)
take bg[SELECTED] tint it by 80%. We hand code that behaviour in, as it
will be wrong a smaller percentage of the time then our current
behaviour.

http://crbug.com/16271 (dark theme bug)
http://crbug.com/13967 (theme color metabug)

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21704

[Evan Stade, 2009-07-27 20:56:39]

ok with me

[tony, 2009-07-27 21:00:12]

LGTM2, just a question.

http://codereview.chromium.org/160188/diff/1/2
File chrome/browser/gtk/gtk_theme_provider.cc (right):

http://codereview.chromium.org/160188/diff/1/2#newcode214
Line 214: frame_color.red = SkColorGetR(shifted) * 257;
Why 257?

[Evan Stade, 2009-07-27 21:02:58]

http://codereview.chromium.org/160188/diff/1/2
File chrome/browser/gtk/gtk_theme_provider.cc (right):

http://codereview.chromium.org/160188/diff/1/2#newcode214
Line 214: frame_color.red = SkColorGetR(shifted) * 257;
On 2009/07/27 21:00:12, tony wrote:
> Why 257?

That's how you convert from 256-scaled color to 65536-scaled color. See
base/gfx/gtk_util.h