Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1646)

Unified Diff: mojo/public/dart/rules.gni

Issue 1601863006: Make sure that Dart depfile dependent is relative to build output (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/dart/rules.gni
diff --git a/mojo/public/dart/rules.gni b/mojo/public/dart/rules.gni
index 8a06b7003fec8cfb07ac3c0e09fc3601bb87b5de..0d80351b2e7db01344278803d6b2874e6ad9d72b 100644
--- a/mojo/public/dart/rules.gni
+++ b/mojo/public/dart/rules.gni
@@ -13,6 +13,7 @@ template("dartx") {
bundle_prefix = target_name
bundle = "$target_gen_dir/${bundle_prefix}.dartx"
snapshot = "$target_gen_dir/${bundle_prefix}_snapshot.bin"
+ depfile_path = "${snapshot}.d"
if (mojo_use_prebuilt_dart_snapshotter) {
dart_snapshotter_path =
@@ -28,6 +29,8 @@ template("dartx") {
action("gen_${bundle_prefix}_snapshot") {
main_dart = invoker.main_dart
+ depfile = depfile_path
+
inputs = [
dart_snapshotter,
]
@@ -42,8 +45,6 @@ template("dartx") {
script =
rebase_path("mojo/public/tools/dart_snapshotter.py", ".", mojo_sdk_root)
- depfile = "$target_gen_dir/${bundle_prefix}_snapshot.bin.d"
-
args = [
rebase_path(dart_snapshotter),
rebase_path(main_dart),
@@ -52,9 +53,9 @@ template("dartx") {
"--snapshot",
rebase_path(snapshot),
"--depfile",
- rebase_path(depfile),
+ rebase_path(depfile_path),
"--build-output",
- "${bundle_prefix}_snapshot.bin",
+ rebase_path(snapshot, root_build_dir), # Relative to build directory
]
deps = [
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698