Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1601863006: Make sure that Dart depfile dependent is relative to build output (Closed)

Created:
4 years, 11 months ago by Cutch
Modified:
4 years, 11 months ago
Reviewers:
zra, tonyg
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make sure that Dart depfile dependent is relative to build output - Follow up fix to my previous CL. R=tonyg@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/cd48972f6e1eecd0b1185e31b3135a530a0f0aa9

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M mojo/public/dart/rules.gni View 1 4 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Cutch
4 years, 11 months ago (2016-01-20 00:06:46 UTC) #3
Cutch
TBR
4 years, 11 months ago (2016-01-20 00:22:31 UTC) #4
tonyg
lgtm
4 years, 11 months ago (2016-01-20 00:25:29 UTC) #5
Cutch
4 years, 11 months ago (2016-01-20 00:29:13 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
cd48972f6e1eecd0b1185e31b3135a530a0f0aa9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698