Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Unified Diff: media/base/android/sdk_media_codec_bridge_unittest.cc

Issue 1601863002: Remove non-batching assumptions from SdkMediaCodecBridgeTest.DoNormal (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/android/sdk_media_codec_bridge_unittest.cc
diff --git a/media/base/android/sdk_media_codec_bridge_unittest.cc b/media/base/android/sdk_media_codec_bridge_unittest.cc
index ef32acf684fecbc2479db94e43d84870c6b2bc6d..08b7ff4c2a4971c355fd202bf9182374a7d9ffb9 100644
--- a/media/base/android/sdk_media_codec_bridge_unittest.cc
+++ b/media/base/android/sdk_media_codec_bridge_unittest.cc
@@ -181,6 +181,7 @@ TEST(SdkMediaCodecBridgeTest, DoNormal) {
input_pts = kPresentationTimeBase;
bool eos = false;
+ size_t total_size = 0;
while (!eos) {
size_t unused_offset = 0;
size_t size = 0;
@@ -205,11 +206,13 @@ TEST(SdkMediaCodecBridgeTest, DoNormal) {
}
ASSERT_GE(output_buf_index, 0);
EXPECT_LE(1u, size);
+ total_size += size;
if (!eos)
EXPECT_EQ(++input_pts, timestamp.InMicroseconds());
qinmin 2016/01/19 00:57:49 should this also be removed? it is possible that t
kraush 2016/01/19 17:33:58 Acknowledged.
ASSERT_LE(input_pts, kPresentationTimeBase + 2);
}
- ASSERT_EQ(input_pts, kPresentationTimeBase + 2);
+ EXPECT_EQ(9216u, total_size);
+ ASSERT_LE(input_pts, kPresentationTimeBase + 2);
}
TEST(SdkMediaCodecBridgeTest, InvalidVorbisHeader) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698