Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 160184: Fix xdg-settings to work around bugs in xdg-mime and kdeinit. (Closed)

Created:
11 years, 4 months ago by Mike Mammarella
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix xdg-settings to work around a bug in xdg-mime which is caused by a bug in kdeinit. BUG=17179 TEST=in kde4 xdg-settings should not take 15s to do "xdg-settings get default-web-browser" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21693

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -0 lines) Patch
M third_party/xdg-utils/scripts/xdg-settings View 1 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/xdg-utils/scripts/xdg-settings.in View 1 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Mike Mammarella
11 years, 4 months ago (2009-07-27 19:06:51 UTC) #1
Evan Martin
Holy crap.
11 years, 4 months ago (2009-07-27 19:09:55 UTC) #2
Evan Stade
I'm probably not the right reviewer for this.
11 years, 4 months ago (2009-07-27 19:50:30 UTC) #3
Evan Martin
http://codereview.chromium.org/160184/diff/1/3 File third_party/xdg-utils/scripts/xdg-settings.in (right): http://codereview.chromium.org/160184/diff/1/3#newcode92 Line 92: if [ "$DE" = kde -a x"$XDG_MIME_FIXED" = ...
11 years, 4 months ago (2009-07-27 20:07:39 UTC) #4
Mike Mammarella
http://codereview.chromium.org/160184/diff/1/3 File third_party/xdg-utils/scripts/xdg-settings.in (right): http://codereview.chromium.org/160184/diff/1/3#newcode92 Line 92: if [ "$DE" = kde -a x"$XDG_MIME_FIXED" = ...
11 years, 4 months ago (2009-07-27 20:25:09 UTC) #5
Evan Martin
LGTM though I don't know this code at all. Is there an upstream to send ...
11 years, 4 months ago (2009-07-27 20:26:04 UTC) #6
Mike Mammarella
11 years, 4 months ago (2009-07-27 20:31:34 UTC) #7
On 2009/07/27 20:26:04, Evan Martin wrote:
> LGTM though I don't know this code at all.  Is there an upstream to send it
to?

xdg-settings is our own addition to xdg-utils, but really the workaround belongs
in xdg-mime as well (or instead). And of course kdeinit should be fixed also.
This is just the most reliable way to fix it for us since we don't control the
version of xdg-mime that's installed on the system. Certainly there are upstream
bugs to be filed though.

Powered by Google App Engine
This is Rietveld 408576698