Fix xdg-settings to work around bugs in xdg-mime and kdeinit.

Fix xdg-settings to work around a bug in xdg-mime which is caused by a bug in kdeinit.
BUG=17179
TEST=in kde4 xdg-settings should not take 15s to do "xdg-settings get default-web-browser"


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21693

[Evan Martin, 2009-07-27 19:09:55]

Holy crap.

[Evan Stade, 2009-07-27 19:50:30]

I'm probably not the right reviewer for this.

[Evan Martin, 2009-07-27 20:07:39]

http://codereview.chromium.org/160184/diff/1/3
File third_party/xdg-utils/scripts/xdg-settings.in (right):

http://codereview.chromium.org/160184/diff/1/3#newcode92
Line 92: if [ "$DE" = kde -a x"$XDG_MIME_FIXED" = x ]; then
-a -z $XDG_MIME_FIXED
?

http://codereview.chromium.org/160184/diff/1/3#newcode107
Line 107: xdg_mime_fixup
Is there a race here with kdeinit starting up?  (That is, is it possible for
this to start kde and then the lower check to do the same?)

[Mike Mammarella, 2009-07-27 20:25:09]

http://codereview.chromium.org/160184/diff/1/3
File third_party/xdg-utils/scripts/xdg-settings.in (right):

http://codereview.chromium.org/160184/diff/1/3#newcode92
Line 92: if [ "$DE" = kde -a x"$XDG_MIME_FIXED" = x ]; then
On 2009/07/27 20:07:39, Evan Martin wrote:
> -a -z $XDG_MIME_FIXED
> ?

Done.

http://codereview.chromium.org/160184/diff/1/3#newcode107
Line 107: xdg_mime_fixup
On 2009/07/27 20:07:39, Evan Martin wrote:
> Is there a race here with kdeinit starting up?  (That is, is it possible for
> this to start kde and then the lower check to do the same?)

The XDG_MIME_FIXED variable is set in the parent shell and inherited by the
subshells inside the ``, so that should not occur.

[Evan Martin, 2009-07-27 20:26:04]

LGTM though I don't know this code at all.  Is there an upstream to send it to?

[Mike Mammarella, 2009-07-27 20:31:34]

On 2009/07/27 20:26:04, Evan Martin wrote:
> LGTM though I don't know this code at all.  Is there an upstream to send it
to?

xdg-settings is our own addition to xdg-utils, but really the workaround belongs
in xdg-mime as well (or instead). And of course kdeinit should be fixed also.
This is just the most reliable way to fix it for us since we don't control the
version of xdg-mime that's installed on the system. Certainly there are upstream
bugs to be filed though.