Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 160183003: Exclude profile and managed user strings for platforms that don't use it. (Closed)

Created:
6 years, 10 months ago by aurimas (slooooooooow)
Modified:
6 years, 10 months ago
Reviewers:
newt (away)
CC:
chromium-reviews
Visibility:
Public.

Description

Exclude profile and managed user strings for platforms that don't use it. BUG=326023 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250831

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -151 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +147 lines, -151 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
aurimas (slooooooooow)
Hey Newton, Please take a look at this CL. Thanks, Aurimas
6 years, 10 months ago (2014-02-12 01:22:18 UTC) #1
newt (away)
lgtm
6 years, 10 months ago (2014-02-12 18:45:28 UTC) #2
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 10 months ago (2014-02-12 18:47:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/160183003/1
6 years, 10 months ago (2014-02-12 18:52:40 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-12 19:12:37 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=49868
6 years, 10 months ago (2014-02-12 19:12:38 UTC) #6
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 10 months ago (2014-02-12 21:27:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/160183003/1
6 years, 10 months ago (2014-02-12 21:29:38 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-12 23:19:01 UTC) #9
Message was sent while issue was closed.
Change committed as 250831

Powered by Google App Engine
This is Rietveld 408576698