Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/objects-inl.h

Issue 1601813009: [interpreter] Add field for source position table to byte code array. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: addressed comment Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects-body-descriptors-inl.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 4033 matching lines...) Expand 10 before | Expand all | Expand 10 after
4044 4044
4045 int BytecodeArray::parameter_count() const { 4045 int BytecodeArray::parameter_count() const {
4046 // Parameter count is stored as the size on stack of the parameters to allow 4046 // Parameter count is stored as the size on stack of the parameters to allow
4047 // it to be used directly by generated code. 4047 // it to be used directly by generated code.
4048 return READ_INT_FIELD(this, kParameterSizeOffset) >> kPointerSizeLog2; 4048 return READ_INT_FIELD(this, kParameterSizeOffset) >> kPointerSizeLog2;
4049 } 4049 }
4050 4050
4051 4051
4052 ACCESSORS(BytecodeArray, constant_pool, FixedArray, kConstantPoolOffset) 4052 ACCESSORS(BytecodeArray, constant_pool, FixedArray, kConstantPoolOffset)
4053 ACCESSORS(BytecodeArray, handler_table, FixedArray, kHandlerTableOffset) 4053 ACCESSORS(BytecodeArray, handler_table, FixedArray, kHandlerTableOffset)
4054 ACCESSORS(BytecodeArray, source_position_table, FixedArray,
4055 kSourcePositionTableOffset)
4054 4056
4055 4057
4056 Address BytecodeArray::GetFirstBytecodeAddress() { 4058 Address BytecodeArray::GetFirstBytecodeAddress() {
4057 return reinterpret_cast<Address>(this) - kHeapObjectTag + kHeaderSize; 4059 return reinterpret_cast<Address>(this) - kHeapObjectTag + kHeaderSize;
4058 } 4060 }
4059 4061
4060 4062
4061 int BytecodeArray::BytecodeArraySize() { return SizeFor(this->length()); } 4063 int BytecodeArray::BytecodeArraySize() { return SizeFor(this->length()); }
4062 4064
4063 4065
(...skipping 3746 matching lines...) Expand 10 before | Expand all | Expand 10 after
7810 #undef WRITE_INT64_FIELD 7812 #undef WRITE_INT64_FIELD
7811 #undef READ_BYTE_FIELD 7813 #undef READ_BYTE_FIELD
7812 #undef WRITE_BYTE_FIELD 7814 #undef WRITE_BYTE_FIELD
7813 #undef NOBARRIER_READ_BYTE_FIELD 7815 #undef NOBARRIER_READ_BYTE_FIELD
7814 #undef NOBARRIER_WRITE_BYTE_FIELD 7816 #undef NOBARRIER_WRITE_BYTE_FIELD
7815 7817
7816 } // namespace internal 7818 } // namespace internal
7817 } // namespace v8 7819 } // namespace v8
7818 7820
7819 #endif // V8_OBJECTS_INL_H_ 7821 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects-body-descriptors-inl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698