Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1601813009: [interpreter] Add field for source position table to byte code array. (Closed)

Created:
4 years, 11 months ago by Yang
Modified:
4 years, 11 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Add field for source position table to byte code array. R=mstarzinger@chromium.org BUG=v8:4690 LOG=N Committed: https://crrev.com/d8cddade5ee262d6ebbdaaf1f352d411cbb9d033 Cr-Commit-Position: refs/heads/master@{#33409}

Patch Set 1 #

Total comments: 1

Patch Set 2 : addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M src/heap/heap.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.h View 2 chunks +7 lines, -1 line 0 comments Download
M src/objects-body-descriptors-inl.h View 1 3 chunks +4 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Yang
4 years, 11 months ago (2016-01-20 13:26:53 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1601813009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1601813009/1
4 years, 11 months ago (2016-01-20 13:29:49 UTC) #3
Michael Starzinger
LGTM with one comment to address. https://codereview.chromium.org/1601813009/diff/1/src/objects-body-descriptors-inl.h File src/objects-body-descriptors-inl.h (right): https://codereview.chromium.org/1601813009/diff/1/src/objects-body-descriptors-inl.h#newcode196 src/objects-body-descriptors-inl.h:196: return offset == ...
4 years, 11 months ago (2016-01-20 13:40:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1601813009/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1601813009/20001
4 years, 11 months ago (2016-01-20 13:47:29 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-20 14:16:19 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 14:17:09 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d8cddade5ee262d6ebbdaaf1f352d411cbb9d033
Cr-Commit-Position: refs/heads/master@{#33409}

Powered by Google App Engine
This is Rietveld 408576698