Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Side by Side Diff: build/common.gypi

Issue 16018009: Pass -lrt when linking AddressSanitizer, ThreadSanitizer, MemorySanitizer binaries on Linux only (w… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 3113 matching lines...) Expand 10 before | Expand all | Expand 10 after
3124 '-fno-omit-frame-pointer', 3124 '-fno-omit-frame-pointer',
3125 '-gline-tables-only', 3125 '-gline-tables-only',
3126 ], 3126 ],
3127 'ldflags!': [ 3127 'ldflags!': [
3128 # Functions interposed by the sanitizers can make ld think 3128 # Functions interposed by the sanitizers can make ld think
3129 # that some libraries aren't needed when they actually are, 3129 # that some libraries aren't needed when they actually are,
3130 # http://crbug.com/234010. As workaround, disable --as-needed. 3130 # http://crbug.com/234010. As workaround, disable --as-needed.
3131 '-Wl,--as-needed', 3131 '-Wl,--as-needed',
3132 ], 3132 ],
3133 }], 3133 }],
3134 ['_toolset=="target" and OS=="linux"', {
3135 'ldflags': [
3136 # http://crbug.com/234010.
3137 '-lrt',
3138 ],
3139 }],
3134 ], 3140 ],
3135 }], 3141 }],
3136 ['asan==1', { 3142 ['asan==1', {
3137 'target_conditions': [ 3143 'target_conditions': [
3138 ['_toolset=="target"', { 3144 ['_toolset=="target"', {
3139 'cflags': [ 3145 'cflags': [
3140 '-fsanitize=address', 3146 '-fsanitize=address',
3141 '-w', # http://crbug.com/162783 3147 '-w', # http://crbug.com/162783
3142 ], 3148 ],
3143 'ldflags': [ 3149 'ldflags': [
3144 '-fsanitize=address', 3150 '-fsanitize=address',
3145 # http://crbug.com/234010.
3146 '-lrt',
3147 ], 3151 ],
3148 'defines': [ 3152 'defines': [
3149 'ADDRESS_SANITIZER', 3153 'ADDRESS_SANITIZER',
3150 ], 3154 ],
3151 }], 3155 }],
3152 ], 3156 ],
3153 'conditions': [ 3157 'conditions': [
3154 ['OS=="mac"', { 3158 ['OS=="mac"', {
3155 'cflags': [ 3159 'cflags': [
3156 '-mllvm -asan-globals=0', # http://crbug.com/196561 3160 '-mllvm -asan-globals=0', # http://crbug.com/196561
(...skipping 1349 matching lines...) Expand 10 before | Expand all | Expand 10 after
4506 # settings in target dicts. SYMROOT is a special case, because many other 4510 # settings in target dicts. SYMROOT is a special case, because many other
4507 # Xcode variables depend on it, including variables such as 4511 # Xcode variables depend on it, including variables such as
4508 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 4512 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
4509 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 4513 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
4510 # files to appear (when present) in the UI as actual files and not red 4514 # files to appear (when present) in the UI as actual files and not red
4511 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 4515 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
4512 # and therefore SYMROOT, needs to be set at the project level. 4516 # and therefore SYMROOT, needs to be set at the project level.
4513 'SYMROOT': '<(DEPTH)/xcodebuild', 4517 'SYMROOT': '<(DEPTH)/xcodebuild',
4514 }, 4518 },
4515 } 4519 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698