Files.app: Added an Esc key handler to the search box.

chrome/browser/resources/file_manager/js/file_manager.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * This variable is checked in SelectFileDialogExtensionBrowserTest.
  * @type {number}
  */
@@ skipping 1031 matching lines @@
     if (loadTimeData.getBoolean('ASH'))
       this.dialogDom_.setAttribute('ash', 'true');
 
     this.filePopup_ = null;
 
     this.searchBoxWrapper_ =
         this.dialogDom_.querySelector('.search-box-wrapper');
     this.searchBox_ = this.dialogDom_.querySelector('#search-box');
     this.searchBox_.addEventListener(
         'input', this.onSearchBoxUpdate_.bind(this));
+    this.searchBox_.addEventListener(
+        'keydown', this.onSearchBoxKeyDown_.bind(this));
     this.searchTextMeasure_ = new TextMeasure(this.searchBox_);
     if (util.platform.newUI()) {
       this.searchIcon_ = this.dialogDom_.querySelector('#search-icon');
       this.searchIcon_.addEventListener(
           'click',
           function() { this.searchBox_.focus(); }.bind(this));
       this.searchClearButton_ =
           this.dialogDom_.querySelector('#search-clear-button');
       this.searchClearButton_.addEventListener(
           'click',
@@ skipping 2454 matching lines @@
 
       // On drive, incremental search is not invoked since we have an auto-
       // complete suggestion instead.
       return;
     }
 
     this.search_(searchString);
   };
 
   /**
+   * Handled to special key such as ESC.

[mtomasz, 2013/05/28 04:07:06]

We usually start with a passive verb.
Eg. Handles special keys such as Escape on the search box. 

[hirono, 2013/05/28 04:24:26]

Done.

+   * Normal text inputs should not be handled by this, should be handled by

[mtomasz, 2013/05/28 04:07:06]

I think that the second line is confusing. The first is enough. Please remove.

[hirono, 2013/05/28 04:24:26]

Done.

+   * onSearchBoxUpdate_.
+   *
+   * @param {Event} event The 'keydown' event.

[mtomasz, 2013/05/28 04:07:06]

Without '' for consistency.

[hirono, 2013/05/28 04:24:26]

Done.

+   * @private
+   */
+  FileManager.prototype.onSearchBoxKeyDown_ = function(event) {
+    // Handle only Esc key now.
+    if (event.keyCode != 27) return;
+    if (this.searchBox_.value) return;
+    if (this.listType_ == FileManager.ListType.DETAIL) {
+      this.table_.list.focus();
+    } else if (this.listType_ == FileManager.ListType.THUMBNAIL) {
+      this.grid_.focus();
+      // The grid not selects its item when focused.

[mtomasz, 2013/05/28 04:07:06]

not selects -> does not select

[hirono, 2013/05/28 04:24:26]

Done.

+      if (this.grid_.dataModel.length != 0)

[mtomasz, 2013/05/28 04:07:06]

Shall we do it for the table list too?

[hirono, 2013/05/28 04:24:26]

Done.

+        this.grid_.selectionModel.selectedIndex = 0;
+    }
+  };
+
+  /**
    * Updates search box's CSS classes.
    * These classes are refered from CSS.
    *
    * @private
    */
   FileManager.prototype.updateSearchBoxStyles_ = function() {
     if (!util.platform.newUI())
       return;
     var TEXT_BOX_PADDING = 16; // in px.
     this.searchBoxWrapper_.classList.toggle('has-text',
@@ skipping 381 matching lines @@
    * Set the flag expressing whether the ctrl key is pressed or not.
    * @param {boolean} flag New value of the flag
    * @private
    */
   FileManager.prototype.setCtrlKeyPressed_ = function(flag) {
     this.ctrlKeyPressed_ = flag;
     this.document_.querySelector('#drive-clear-local-cache').canExecuteChange();
     this.document_.querySelector('#drive-reload').canExecuteChange();
   };
 })();