Issue 160180: Merge 21312 - This CL fixes issue 2780 RTL: Omnibar message "Press Tab to s...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 160180: Merge 21312 - This CL fixes issue 2780 RTL: Omnibar message "Press Tab to s... (Closed)

Created:
11 years, 5 months ago by laforge

Modified:
9 years, 7 months ago

Reviewers:
xji

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/branches/195/src/

Visibility:
Public.

Description

Merge 21312 - This CL fixes issue 2780 RTL: Omnibar message "Press Tab to search Google" doesn't show correctly in a "New Tab" for RTL locales Because of the bug in PosFromChar() (see bug report for detailed information), we actually calculate the width of the string ourselves using font.GetStringWidth(). BUG=http://crbug.com/2780 TEST= 1 Start Chrome with a *new user data directory* and make sure the UI language is Hebrew. 2 Type www.google.com in the omnibox and press Enter. 3 Close and reopen the browser. 4 Type character "h" in Ominibox 5 Message "Press Tab to search Google" should show correctly, not only "Tab" is displayed Review URL: http://codereview.chromium.org/155789 TBR=xji@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21667

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -34 lines)			Patch
	MM	chrome/browser/views/location_bar_view.h	View		1 chunk	+12 lines, -10 lines	0 comments	Download
	MM	chrome/browser/views/location_bar_view.cc	View		5 chunks	+25 lines, -24 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages