Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Unified Diff: sandbox/src/process_policy_test.cc

Issue 160176: Merge 21292 - Fix FORWARD_NULL defects reported by Coverity. We should... (Closed) Base URL: svn://chrome-svn/chrome/branches/195/src/
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sandbox/src/named_pipe_policy_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/src/process_policy_test.cc
===================================================================
--- sandbox/src/process_policy_test.cc (revision 21664)
+++ sandbox/src/process_policy_test.cc (working copy)
@@ -99,7 +99,7 @@
if (argc != 1) {
return SBOX_TEST_FAILED_TO_EXECUTE_COMMAND;
}
- if ((NULL != argv) && (NULL == argv[0])) {
+ if ((NULL == argv) || (NULL == argv[0])) {
return SBOX_TEST_FAILED_TO_EXECUTE_COMMAND;
}
std::wstring path = MakeFullPathToSystem32(argv[0]);
@@ -163,7 +163,7 @@
if (argc != 1)
return SBOX_TEST_FAILED_TO_EXECUTE_COMMAND;
- if ((NULL != argv) && (NULL == argv[0]))
+ if ((NULL == argv) || (NULL == argv[0]))
return SBOX_TEST_FAILED_TO_EXECUTE_COMMAND;
std::wstring path = MakeFullPathToSystem32(argv[0]);
Property changes on: sandbox\src\process_policy_test.cc
___________________________________________________________________
Added: svn:mergeinfo
Merged /branches/chrome_webkit_merge_branch/sandbox/src/process_policy_test.cc:r69-2775
Merged /trunk/src/sandbox/src/process_policy_test.cc:r21292
« no previous file with comments | « sandbox/src/named_pipe_policy_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698