Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1601743009:
Add GM for SkPixelXorXfermode (Closed)
|
Created:
4 years, 11 months ago by robertphillips Modified:
4 years, 11 months ago Reviewers:
reed1 CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionAdd GM for SkPixelXorXfermode
This is in preparation for adding a gpu implementation
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1601743009
Committed: https://skia.googlesource.com/skia/+/37771c349ef3d3b1b524e420d8d1bd634cfe60c1
Patch Set 1 #Patch Set 2 : eraseRGB -> eraseARGB #Messages
Total messages: 21 (10 generated)
Description was changed from ========== Add GM for SkPixelXorXfermode ========== to ========== Add GM for SkPixelXorXfermode GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Add GM for SkPixelXorXfermode GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Add GM for SkPixelXorXfermode This is in preparation for adding a gpu implementation GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
robertphillips@google.com changed reviewers: + reed@google.com
I thought we were getting to remove this mode?
It is publicly exposed in the Android API :(
ping
lgtm
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1601743009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1601743009/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1601743009/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1601743009/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robertphillips@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com Link to the patchset: https://codereview.chromium.org/1601743009/#ps20001 (title: "eraseRGB -> eraseARGB")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1601743009/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1601743009/20001
Message was sent while issue was closed.
Description was changed from ========== Add GM for SkPixelXorXfermode This is in preparation for adding a gpu implementation GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Add GM for SkPixelXorXfermode This is in preparation for adding a gpu implementation GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/37771c349ef3d3b1b524e420d8d1bd634cfe60c1 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/37771c349ef3d3b1b524e420d8d1bd634cfe60c1 |
