Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1601743002: [regexp] do not include irregexp interpreter by default. (Closed)

Created:
4 years, 11 months ago by Yang
Modified:
4 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] do not include irregexp interpreter by default. R=jkummerow@chromium.org Committed: https://crrev.com/4836180143243d52437502afa37d1ca7650cee4d Cr-Commit-Position: refs/heads/master@{#33368}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -15 lines) Patch
M src/regexp/bytecodes-irregexp.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/regexp/interpreter-irregexp.h View 2 chunks +4 lines, -1 line 0 comments Download
M src/regexp/interpreter-irregexp.cc View 3 chunks +4 lines, -1 line 0 comments Download
M src/regexp/regexp-macro-assembler-irregexp.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/regexp/regexp-macro-assembler-irregexp.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M src/regexp/regexp-macro-assembler-irregexp-inl.h View 2 chunks +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Issue 1574113009 Patch 1

Messages

Total messages: 7 (2 generated)
Yang
4 years, 11 months ago (2016-01-18 14:09:47 UTC) #1
Jakob Kummerow
lgtm
4 years, 11 months ago (2016-01-18 15:32:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1601743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1601743002/1
4 years, 11 months ago (2016-01-18 15:50:30 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-18 16:11:26 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-18 16:12:34 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4836180143243d52437502afa37d1ca7650cee4d
Cr-Commit-Position: refs/heads/master@{#33368}

Powered by Google App Engine
This is Rietveld 408576698