[regexp] back refs must not start/end in the middle of a surrogate pair

src/regexp/regexp-macro-assembler.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/regexp/regexp-macro-assembler.h"
 
 #include "src/assembler.h"
 #include "src/isolate-inl.h"
 #include "src/regexp/regexp-stack.h"
 #include "src/simulator.h"
 
 namespace v8 {
 namespace internal {
 
 RegExpMacroAssembler::RegExpMacroAssembler(Isolate* isolate, Zone* zone)
     : slow_safe_compiler_(false),
       global_mode_(NOT_GLOBAL),
       isolate_(isolate),
       zone_(zone) {}
 
 
 RegExpMacroAssembler::~RegExpMacroAssembler() {
 }
 
 
+void RegExpMacroAssembler::CheckNotInSurrogatePair(int cp_offset,
+                                                   Label* on_failure) {
+  Label ok;
+  // Check that current character is not a trail surrogate.
+  LoadCurrentCharacter(cp_offset, &ok, true, 1);

[erikcorry, 2016/01/26 16:25:06]

True, 1 are default args and not needed.

[Yang, 2016/01/27 09:06:06]

Done.

+  CheckCharacterNotInRange(kTrailSurrogateStart, kTrailSurrogateEnd, &ok);
+  // Check that previous character is not a lead surrogate.
+  LoadCurrentCharacter(cp_offset - 1, &ok, true, 1);
+  CheckCharacterNotInRange(kLeadSurrogateStart, kLeadSurrogateEnd, &ok);

[erikcorry, 2016/01/26 16:25:06]

CheckCharacterInRange(on_failure) ?

[Yang, 2016/01/27 09:06:06]

Done.

+  // Looks like we are right in between a lead and a trail surrogate.
+  GoTo(on_failure);
+  Bind(&ok);
+}
+
+
 #ifndef V8_INTERPRETED_REGEXP  // Avoid unused code, e.g., on ARM.
 
 NativeRegExpMacroAssembler::NativeRegExpMacroAssembler(Isolate* isolate,
                                                        Zone* zone)
     : RegExpMacroAssembler(isolate, zone) {}
 
 
 NativeRegExpMacroAssembler::~NativeRegExpMacroAssembler() {
 }
 
@@ skipping 258 matching lines @@
   }
   *stack_base = new_stack_base;
   intptr_t stack_content_size = old_stack_base - stack_pointer;
   return new_stack_base - stack_content_size;
 }
 
 #endif  // V8_INTERPRETED_REGEXP
 
 }  // namespace internal
 }  // namespace v8