Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1601583002: Cleanup: Remove unused ui::ResourceBundle::ImageRTL (Closed)

Created:
4 years, 11 months ago by tapted
Modified:
4 years, 11 months ago
Reviewers:
halliwell, sky
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, karandeepb
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove unused ui::ResourceBundle::ImageRTL This was added in r132091 to support GTK, but resource_bundle_gtk is no more. And, e.g., ImageRTL::RTL_ENABLED doesn't appear anywhere in Chrome. De-lint cast_resource_delegate.cc to avoid presubmit errors. Committed: https://crrev.com/04fdb88a491e39cc3ca73c19dc5d1a7acce2263c Cr-Commit-Position: refs/heads/master@{#370197}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -59 lines) Patch
M chrome/browser/ui/cocoa/screen_capture_notification_ui_cocoa.mm View 1 chunk +1 line, -2 lines 0 comments Download
M chromecast/common/cast_resource_delegate.h View 1 chunk +1 line, -3 lines 0 comments Download
M chromecast/common/cast_resource_delegate.cc View 4 chunks +9 lines, -11 lines 0 comments Download
M ui/base/resource/resource_bundle.h View 3 chunks +1 line, -13 lines 0 comments Download
M ui/base/resource/resource_bundle.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/base/resource/resource_bundle_android.cc View 1 chunk +1 line, -3 lines 0 comments Download
M ui/base/resource/resource_bundle_auralinux.cc View 1 chunk +1 line, -3 lines 0 comments Download
M ui/base/resource/resource_bundle_ios.mm View 2 chunks +2 lines, -5 lines 0 comments Download
M ui/base/resource/resource_bundle_mac.mm View 2 chunks +2 lines, -5 lines 0 comments Download
M ui/base/resource/resource_bundle_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M ui/base/resource/resource_bundle_win.cc View 1 chunk +1 line, -4 lines 0 comments Download
M ui/wm/core/shadow_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
tapted
sky: please review for ui/{base.wm} halliwell: please review for OWNERS in src/chromecast
4 years, 11 months ago (2016-01-18 06:21:04 UTC) #5
halliwell
On 2016/01/18 06:21:04, tapted wrote: > sky: please review for ui/{base.wm} > halliwell: please review ...
4 years, 11 months ago (2016-01-19 14:43:59 UTC) #6
sky
LGTM
4 years, 11 months ago (2016-01-19 18:45:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1601583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1601583002/1
4 years, 11 months ago (2016-01-19 20:49:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-19 22:06:47 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-19 22:09:29 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/04fdb88a491e39cc3ca73c19dc5d1a7acce2263c
Cr-Commit-Position: refs/heads/master@{#370197}

Powered by Google App Engine
This is Rietveld 408576698