[EventSource] retry field including non-digit chars should be ignored

[EventSource] retry field including non-digit chars should be ignored

The spec says that retry field is valid when the value consists of only ASCII
digits.
Currently Chrome accepts "retry: 12a", "retry:    5", etc. This change fixes
it.

BUG=578709
Committed: https://crrev.com/028688f6ee4ef54f469ec8150bb21c42603ae2b7
Cr-Commit-Position: refs/heads/master@{#371958}

[yhirano, 2016-01-20 06:48:28]

yhirano@chromium.org changed reviewers:
+ tyoshino@chromium.org

[tyoshino (SeeGerritForStatus), 2016-01-25 05:08:44]

lgtm

https://codereview.chromium.org/1601553004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/page/EventSource.cpp (right):

https://codereview.chromium.org/1601553004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/page/EventSource.cpp:415: }
run this code only when valueLength is not 0?

you've placed this here because you plan to remove L416-417?

[yhirano, 2016-01-25 11:22:34]

https://codereview.chromium.org/1601553004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/page/EventSource.cpp (right):

https://codereview.chromium.org/1601553004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/page/EventSource.cpp:415: }
On 2016/01/25 05:08:44, tyoshino wrote:
> run this code only when valueLength is not 0?
> 
> you've placed this here because you plan to remove L416-417?

I want to do it, but I'm not planning it.
It's just for not increasing the nesting level.

[tyoshino (SeeGerritForStatus), 2016-01-25 11:37:08]

lgtm

[yhirano, 2016-01-25 11:58:26]

yhirano@chromium.org changed reviewers:
+ japhet@chromium.org

[yhirano, 2016-01-25 11:58:27]

+japhet for OWNER review.

[Nate Chapin, 2016-01-27 23:33:31]

lgtm

[yhirano, 2016-01-28 00:25:41]

The CQ bit was checked by yhirano@chromium.org

[yhirano, 2016-01-28 00:25:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
tyoshino@chromium.org
Link to the patchset: https://codereview.chromium.org/1601553004/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-01-28 00:26:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1601553004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1601553004/60001

[commit-bot: I haz the power, 2016-01-28 01:51:18]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-01-28 02:05:11]

Description was changed from

==========
[EventSource] retry field including non-digit chars should be ignored

The spec says that retry field is valid when the value consists of only ASCII
digits.
Currently Chrome accepts "retry: 12a", "retry:    5", etc. This change fixes
it.

BUG=578709
==========

to

==========
[EventSource] retry field including non-digit chars should be ignored

The spec says that retry field is valid when the value consists of only ASCII
digits.
Currently Chrome accepts "retry: 12a", "retry:    5", etc. This change fixes
it.

BUG=578709

Committed: https://crrev.com/028688f6ee4ef54f469ec8150bb21c42603ae2b7
Cr-Commit-Position: refs/heads/master@{#371958}
==========

[commit-bot: I haz the power, 2016-01-28 02:05:12]

Patchset 4 (id:??) landed as
https://crrev.com/028688f6ee4ef54f469ec8150bb21c42603ae2b7
Cr-Commit-Position: refs/heads/master@{#371958}