When there are no images to replace a blacklisted page, putting filler...

When there are no images to replace a blacklisted page, putting filler
causes a blank spot which no other thumbnail can be dragged to. This 
will go away on page refresh, but we can easily redraw all items
keeping the filler in the rightmost indices.

BUG=17738

[arv (Not doing code reviews), 2009-07-27 17:25:08]

LGTM

The intended behavior was to replace it with a filler. I'm not sure which
behavior is better though. I think that the whole drop to swap is flawed and I
would prefer drop to insert.

Considering this is an edge case where your code is slightly less bad I approve
this code.

[pierre.lafayette, 2009-07-27 18:12:23]

On 2009/07/27 17:25:08, arv wrote:
> LGTM
> 
> The intended behavior was to replace it with a filler. I'm not sure which
> behavior is better though. I think that the whole drop to swap is flawed and I
> would prefer drop to insert.
> 
> Considering this is an edge case where your code is slightly less bad I
approve
> this code.

Considering that the most visited pages are ordered it didn't seem intuitive to
have a filler thumbnail in the middle of your actual page thumbnails. Especially
since you could not drag one of your other pages to that spot. Alternatively we
could have allowed drag and drop to work on the inserted filler. However that
would be unnecessary work for the user as a page refresh would put things in
order. 

Anyhow, I can't commit so this one's on you. Thanks for the review.

[pierre.lafayette, 2009-07-27 18:42:52]

When there are no images to replace a blacklisted page, putting filler
causes a blank spot which no other thumbnail can be dragged to. This
will go away on page refresh, but we can easily redraw all items

keeping the filler in the rightmost indices.


http://code.google.com/p/chromium/issues/detail?id=17738

Please Review: http://codereview.chromium.org/160152

Thanks.
-- 
Pierre.

[arv (Not doing code reviews), 2009-07-28 18:51:11]

Checked in as r21869