Try loading msdiaNNN.dll if CoCreateInstance(CLSID_DiaSource) fails

Try loading msdiaNNN.dll if CoCreateInstance(CLSID_DiaSource) fails

Because tools/windows/symupload/symupload.cc uses `nullptr` (which
requires VS2010), the CLSID comparison is only performed for msdia100.dll
and later. When compiling with an older (or future) CLSID_DiaSource, we
retain the existing behaviour (i.e. fail if CoCreateInstance fails).

R=ivanpe@chromium.org
BUG=https://bugzilla.mozilla.org/show_bug.cgi?id=1236343

[poiru, 2016-01-17 19:07:27]

Description was changed from

==========
Try loading msdiaNNN.dll if CoCreateInstance(CLSID_DiaSource) fails

Because tools/windows/symupload/symupload.cc uses `nullptr` (which
requires VS2010), the CLSID comparison is only performed for msdia100.dll
and later. When compiling with an older (or future) CLSID_DiaSource, we
retain the existing behaviour (i.e. fail if CoCreateInstance fails).

R=ted@mielczarek.org
BUG=
==========

to

==========
Try loading msdiaNNN.dll if CoCreateInstance(CLSID_DiaSource) fails

Because tools/windows/symupload/symupload.cc uses `nullptr` (which
requires VS2010), the CLSID comparison is only performed for msdia100.dll
and later. When compiling with an older (or future) CLSID_DiaSource, we
retain the existing behaviour (i.e. fail if CoCreateInstance fails).

R=ted@mielczarek.org
BUG=https://bugzilla.mozilla.org/show_bug.cgi?id=1236343
==========

[poiru, 2016-02-17 05:01:44]

birunthan@mohanathas.com changed reviewers:
+ ivanpe@chromium.org
- ted@mielczarek.org

[ivanpe, 2016-02-17 05:59:31]

On 2016/01/17 19:03:47, poiru wrote:

LGTM

[poiru, 2016-02-17 15:19:41]

Description was changed from

==========
Try loading msdiaNNN.dll if CoCreateInstance(CLSID_DiaSource) fails

Because tools/windows/symupload/symupload.cc uses `nullptr` (which
requires VS2010), the CLSID comparison is only performed for msdia100.dll
and later. When compiling with an older (or future) CLSID_DiaSource, we
retain the existing behaviour (i.e. fail if CoCreateInstance fails).

R=ted@mielczarek.org
BUG=https://bugzilla.mozilla.org/show_bug.cgi?id=1236343
==========

to

==========
Try loading msdiaNNN.dll if CoCreateInstance(CLSID_DiaSource) fails

Because tools/windows/symupload/symupload.cc uses `nullptr` (which
requires VS2010), the CLSID comparison is only performed for msdia100.dll
and later. When compiling with an older (or future) CLSID_DiaSource, we
retain the existing behaviour (i.e. fail if CoCreateInstance fails).

R=ivanpe@chromium.org
BUG=https://bugzilla.mozilla.org/show_bug.cgi?id=1236343
==========