SDK gets analyzer sources.

SDK gets analyzer sources.

With this change, analyzer and server sources will appear in `sdk/lib`.

Having the sources in the SDK is a prerequisite to consuming them in a spawned Isolate (needed for dynamic analyzer plugin loading).

R=brianwilkerson@google.com, whesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/68f077c47bfd782f1599725ce046bd8129f1e7ec

[pquitslund, 2016-01-19 22:13:41]

pquitslund@google.com changed reviewers:
+ brianwilkerson@google.com, whesse@google.com

[Brian Wilkerson, 2016-01-19 22:20:45]

LGTM, but I could easily miss problems.

[Bill Hesse, 2016-01-20 18:51:39]

LGTM.  Please check on how much the size of the Dart SDK increases with this
change.

https://codereview.chromium.org/1601373002/diff/1/tools/create_sdk.py
File tools/create_sdk.py (right):

https://codereview.chromium.org/1601373002/diff/1/tools/create_sdk.py#newcode41
tools/create_sdk.py:41: # ....lib/
Please update this comment to show the new directories.

[pquitslund, 2016-02-03 17:37:29]

Description was changed from

==========
SDK gets analyzer sources.

With this change, analyzer and server sources will appear in `sdk/lib`.

Having the sources in the SDK is a prerequisite to consuming them in a spawned
Isolate (needed for dynamic analyzer plugin loading).
==========

to

==========
SDK gets analyzer sources.

With this change, analyzer and server sources will appear in `sdk/lib`.

Having the sources in the SDK is a prerequisite to consuming them in a spawned
Isolate (needed for dynamic analyzer plugin loading).

R=brianwilkerson@google.com, whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/68f077c47bfd782f1599725ce046bd8129f1e7ec
==========

[pquitslund, 2016-02-03 17:37:31]

Committed patchset #1 (id:1) manually as
68f077c47bfd782f1599725ce046bd8129f1e7ec (presubmit successful).

[pquitslund, 2016-02-03 17:38:10]

Thanks!

https://codereview.chromium.org/1601373002/diff/1/tools/create_sdk.py
File tools/create_sdk.py (right):

https://codereview.chromium.org/1601373002/diff/1/tools/create_sdk.py#newcode41
tools/create_sdk.py:41: # ....lib/
On 2016/01/20 18:51:39, Bill Hesse wrote:
> Please update this comment to show the new directories.

Done.