Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1145)

Issue 1601353002: partial fix for #414, nSM message for dcall should show correct target (Closed)

Created:
4 years, 11 months ago by Jennifer Messerly
Modified:
4 years, 11 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

partial fix for #414, nSM message for dcall should show correct target R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/635620c97f0316cfadada3afb897eff3f2a9cdd5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M lib/runtime/dart/_operations.js View 3 chunks +3 lines, -2 lines 0 comments Download
M test/browser/runtime_tests.js View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
The error message was incorrectly showing 'null' as the target
4 years, 11 months ago (2016-01-19 21:21:15 UTC) #2
vsm
lgtm
4 years, 11 months ago (2016-01-19 21:23:16 UTC) #3
Jennifer Messerly
4 years, 11 months ago (2016-01-19 21:33:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
635620c97f0316cfadada3afb897eff3f2a9cdd5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698