Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 160133: Add strings for SSL3.0 and TLS1.0 config options for Linux. (Closed)

Created:
11 years, 5 months ago by mattm
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add strings for SSL3.0 and TLS1.0 config options for Linux. BUG=11507 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21605

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
mattm
11 years, 5 months ago (2009-07-25 00:39:02 UTC) #1
darin (slow to review)
LGTM
11 years, 5 months ago (2009-07-25 00:48:28 UTC) #2
wtc
11 years, 4 months ago (2009-07-29 00:42:25 UTC) #3
LGTM.

http://codereview.chromium.org/160133/diff/1/2
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/160133/diff/1/2#newcode3309
Line 3309: <message name="IDS_OPTIONS_SSL_USESSL3" desc="The label of the 'Use
SSL 3.0' checkbox (Only used on Linux.)">
Nit: would be nice for these two options to follow
IDS_OPTIONS_SSL_USESSL2 immediately because they're related.

Powered by Google App Engine
This is Rietveld 408576698