Use GetLastCommittedOrigin instead of GetLastCommittedURL in bluetooth chooser

chrome/browser/ui/android/bluetooth_chooser_android.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/android/bluetooth_chooser_android.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/ssl/chrome_security_state_model_client.h"
 #include "chrome/browser/ui/android/view_android_helper.h"
 #include "content/public/browser/android/content_view_core.h"
 #include "jni/BluetoothChooserDialog_jni.h"
 #include "ui/android/window_android.h"
+#include "url/origin.h"
 
 using base::android::AttachCurrentThread;
 using base::android::ConvertUTF8ToJavaString;
 using base::android::ConvertUTF16ToJavaString;
 using base::android::ScopedJavaLocalRef;
 
 BluetoothChooserAndroid::BluetoothChooserAndroid(
     content::WebContents* web_contents,
     const EventHandler& event_handler,
-    const GURL& origin)
+    const url::Origin& origin)
     : event_handler_(event_handler) {
   base::android::ScopedJavaLocalRef<jobject> window_android =
       content::ContentViewCore::FromWebContents(
           web_contents)->GetWindowAndroid()->GetJavaObject();
 
   ChromeSecurityStateModelClient* security_model_client =
       ChromeSecurityStateModelClient::FromWebContents(web_contents);
   DCHECK(security_model_client);
 
   // Create (and show) the BluetoothChooser dialog.
   JNIEnv* env = AttachCurrentThread();
   ScopedJavaLocalRef<jstring> origin_string =
-      ConvertUTF8ToJavaString(env, origin.spec());
+      ConvertUTF8ToJavaString(env, origin.Serialize());

[ncarter (slow), 2016/01/20 20:59:44]

What if the origin is unique? Do we still want to show a chooser in that case?

One way that can happen, is with <iframe sandbox>. Also, "data:" URLs are placed
in unique origins.

[Jeffrey Yasskin, 2016/01/20 21:29:58]

Good point. We don't want to show the user the string of a unique origin, but we
need to do something principled instead. According to
https://w3c.github.io/webappsec-secure-contexts/#potentially-trustworthy-origin,
data: URLs aren't secure contexts, so they won't show up here, but sandbox'ed
iframes might.

Jun, could you explicitly block unique origins in
BluetoothDispatcherHost::OnRequestDevice(), with a SecurityError ... add it to
https://code.google.com/p/chromium/codesearch/#chromium/src/third_party/WebKi...,
call it RequestDeviceWithUniqueOrigin, and in WebBluetoothError.cpp, give it the
string "requestDevice() called from sandboxed or otherwise unique origin." We'll
probably do something to allow those in the future, but we need to check with
the security-UX folks, and I don't want to block this patch on that.

[ncarter (slow), 2016/01/20 22:00:20]

Thanks for the spec link, that was good reading.

This pattern of falling back to the URL origin has come up in a couple different
places already: (see e.g.
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/sit...).
I am starting to wonder if it ought to be a getter that does that by default. In
any case: I'm very much open to suggestions for how to make
GetLastCommittedOrigin() easier for clients to use!

[juncai, 2016/01/21 17:47:42]

Done.

   java_dialog_.Reset(Java_BluetoothChooserDialog_create(
       env, window_android.obj(), origin_string.obj(),
       security_model_client->GetSecurityInfo().security_level,
       reinterpret_cast<intptr_t>(this)));
 }
 
 BluetoothChooserAndroid::~BluetoothChooserAndroid() {
   if (!java_dialog_.is_null()) {
     Java_BluetoothChooserDialog_closeDialog(AttachCurrentThread(),
                                             java_dialog_.obj());
@@ skipping 98 matching lines @@
 void BluetoothChooserAndroid::ShowNeedLocationPermissionLink(
     JNIEnv* env,
     const JavaParamRef<jobject>& obj) {
   event_handler_.Run(Event::SHOW_NEED_LOCATION_HELP, "");
 }
 
 // static
 bool BluetoothChooserAndroid::Register(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }