third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.h - Issue 1601303003: Fix smooth scroll overshooting when mouse held down in scrollbar track.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.h

Issue 1601303003: Fix smooth scroll overshooting when mouse held down in scrollbar track. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.h ('K') | « third_party/WebKit/Source/platform/scroll/ScrollbarTheme.cpp ('k') | third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.h

diff --git a/third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.h b/third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.h

index 0af2c0444fc2d0c34e8b2978d7d5b034e8dd9665..260a3b148e825087d6df0b140b49e8fa31499caf 100644

--- a/third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.h

+++ b/third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.h

@@ -45,7 +45,7 @@ public:

int scrollbarMargin() const override;

bool usesOverlayScrollbars() const override;

- int thumbPosition(const ScrollbarThemeClient&) override;

+ int thumbPosition(const ScrollbarThemeClient&, float scrollPosition) override;

int thumbLength(const ScrollbarThemeClient&) override;

bool hasButtons(const ScrollbarThemeClient&) override { return false; }