third_party/WebKit/LayoutTests/fast/scroll-behavior/smooth-scroll/track-scroll.html - Issue 1601303003: Fix smooth scroll overshooting when mouse held down in scrollbar track.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/scroll-behavior/smooth-scroll/track-scroll.html

Issue 1601303003: Fix smooth scroll overshooting when mouse held down in scrollbar track. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/scroll-behavior/smooth-scroll/track-scroll-expected.txt » ('j') | third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../../resources/js-test.js"></script>

	3 <style>

	4 body {

	5 height: 1800px;

	6 }

	7 </style>

	8 <body>

	9 <script>

	10 window.jsTestIsAsync = true;

	11

	12 description("This test scrolls by clicking in the scrollbar track.");

	13

	14 // Compute ScrollableArea::pageStep.

	15 var pageStep = innerHeight * 0.875;

	16 if (navigator.userAgent.indexOf("Mac OS X") >= 0)

	17 pageStep = Math.max(pageStep, innerHeight - 40);
	jbroman 2016/01/19 22:39:12 Unfortunate to have this hard-coded in a layout te Unfortunate to have this hard-coded in a layout test. I guess there's no easy way around this? skobes 2016/01/19 23:44:14 In theory we could expose it through window.intern Show quoted text On 2016/01/19 22:39:12, jbroman wrote: > Unfortunate to have this hard-coded in a layout test. I guess there's no easy > way around this? In theory we could expose it through window.internals somehow, but that seems like overkill. It looks like fast/events/platform-wheelevent-paging-xy-in-scrolling-page.html does this as well.
	18

	19 onload = function() {

	20 if (!window.eventSender \|\| !window.internals) {

	21 finishJSTest();

	22 return;

	23 }

	24

	25 // Turn on smooth scrolling.

	26 internals.settings.setScrollAnimatorEnabled(true);

	27

	28 // Click in the vertical scrollbar track, below the thumb.

	29 eventSender.mouseMoveTo(790, 280);

	30 eventSender.mouseDown();

	31 eventSender.mouseUp();

	32

	33 // A second click should have no effect since we will be under the thumb

	34 // by the time the animation completes.

	35 eventSender.mouseDown();

	36 eventSender.mouseUp();

	37

	38 shouldBecomeEqual("scrollY", "pageStep", function() {

	39 requestAnimationFrame(function() {

	40 // Make sure we stopped here.

	41 shouldBe("scrollY", "pageStep");

	42 finishJSTest();

	43 });

	44 });

	45 };

	46 </script>

	47 </body>

OLD	NEW