third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.h - Issue 1601283003: DevTools: deoilpanize inspector/v8 and related classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.h

Issue 1601283003: DevTools: deoilpanize inspector/v8 and related classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp ('k') | third_party/WebKit/Source/web/WebDevToolsAgentImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.h

diff --git a/third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.h b/third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.h

index 2f3ae8d8cb4929e9627d9130a7e838a02d56f1d0..a99266bf50023ac412a1733df003d2f2d5328546 100644

--- a/third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.h

+++ b/third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.h

@@ -64,7 +64,7 @@ public:

// TODO(ikilpatrick): implement when we implement devtools support.

void reportBlockedScriptExecutionToInspector(const String& directiveText) final { }

void addConsoleMessage(PassRefPtrWillBeRawPtr<ConsoleMessage>) final { }

- void logExceptionToConsole(const String& errorMessage, int scriptId, const String& sourceURL, int lineNumber, int columnNumber, PassRefPtrWillBeRawPtr<ScriptCallStack>) final { }

+ void logExceptionToConsole(const String& errorMessage, int scriptId, const String& sourceURL, int lineNumber, int columnNumber, PassRefPtr<ScriptCallStack>) final { }

DECLARE_VIRTUAL_TRACE();