third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h - Issue 1601283003: DevTools: deoilpanize inspector/v8 and related classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h

Issue 1601283003: DevTools: deoilpanize inspector/v8 and related classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgent.h ('k') | third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h

diff --git a/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h b/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h

index 8f6bbcd01985488ce89ce6281280734aee064973..86441482b808bc70c40323f95ba1a742f1c3b9ef 100644

--- a/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h

+++ b/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h

@@ -129,7 +129,7 @@ public:

void removeBreakpoint(const String& scriptId, int lineNumber, int columnNumber, BreakpointSource) override;

// Async call stacks implementation

- PassRefPtrWillBeRawPtr<ScriptAsyncCallStack> currentAsyncStackTraceForConsole() override;

+ PassRefPtr<ScriptAsyncCallStack> currentAsyncStackTraceForConsole() override;

int traceAsyncOperationStarting(const String& description) override;

void traceAsyncCallbackStarting(int operationId) override;

void traceAsyncCallbackCompleted() override;

@@ -199,11 +199,11 @@ private:

StepOut

};

- RawPtrWillBeWeakPersistent<InjectedScriptManager> m_injectedScriptManager;

+ InjectedScriptManager* m_injectedScriptManager;

V8DebuggerImpl* m_debugger;

int m_contextGroupId;

bool m_enabled;

- RawPtrWillBeWeakPersistent<InspectorState> m_state;

+ InspectorState* m_state;

InspectorFrontend::Debugger* m_frontend;

v8::Isolate* m_isolate;

RefPtr<ScriptState> m_pausedScriptState;