third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp - Issue 1601283003: DevTools: deoilpanize inspector/v8 and related classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp

Issue 1601283003: DevTools: deoilpanize inspector/v8 and related classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.h ('k') | third_party/WebKit/Source/core/inspector/InspectorInspectorAgent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp

index eb3a69bf0a2453a3e5c4e3a8e474b7429b847d1f..1fe4c09225c3bcf16576dae33d89b4917c53413a 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp

@@ -352,7 +352,7 @@ void InspectorHeapProfilerAgent::addInspectedHeapObject(ErrorString* errorString

*errorString = "Invalid heap snapshot object id";

return;

}

- m_injectedScriptManager->injectedScriptHost()->addInspectedObject(adoptPtrWillBeNoop(new InspectableHeapObject(id)));

+ m_injectedScriptManager->injectedScriptHost()->addInspectedObject(adoptPtr(new InspectableHeapObject(id)));

}

void InspectorHeapProfilerAgent::getHeapObjectId(ErrorString* errorString, const String& objectId, String* heapSnapshotObjectId)

@@ -380,7 +380,6 @@ void InspectorHeapProfilerAgent::getHeapObjectId(ErrorString* errorString, const

DEFINE_TRACE(InspectorHeapProfilerAgent)

{

- visitor->trace(m_injectedScriptManager);

visitor->trace(m_heapStatsUpdateTask);

InspectorBaseAgent::trace(visitor);

}