Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp

Issue 1601283003: DevTools: deoilpanize inspector/v8 and related classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments addressed. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp
diff --git a/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp
index a310ae81d03fb0f8293b221cbfedc963460e60c7..d62ef9b07208e07864aef3db28757c3d5b2ab750 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp
+++ b/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp
@@ -59,12 +59,6 @@ InspectorConsoleAgent::~InspectorConsoleAgent()
#endif
}
-DEFINE_TRACE(InspectorConsoleAgent)
-{
- visitor->trace(m_injectedScriptManager);
- InspectorBaseAgent::trace(visitor);
-}
-
void InspectorConsoleAgent::enable(ErrorString*)
{
if (m_enabled)
@@ -118,6 +112,12 @@ void InspectorConsoleAgent::addMessageToConsole(ConsoleMessage* consoleMessage)
m_debuggerAgent->breakProgram(InspectorFrontend::Debugger::Reason::Assert, nullptr);
}
+void InspectorConsoleAgent::clearAllMessages()
+{
+ ErrorString error;
+ clearMessages(&error);
+}
+
void InspectorConsoleAgent::consoleMessagesCleared()
{
m_injectedScriptManager->releaseObjectGroup("console");
@@ -226,7 +226,7 @@ void InspectorConsoleAgent::sendConsoleMessageToFrontend(ConsoleMessage* console
if (consoleMessage->callStack()) {
if (consoleMessage->callStack()->size())
jsonObj->setStackTrace(consoleMessage->callStack()->buildInspectorArray());
- RefPtrWillBeRawPtr<ScriptAsyncCallStack> asyncCallStack = consoleMessage->callStack()->asyncCallStack();
+ RefPtr<ScriptAsyncCallStack> asyncCallStack = consoleMessage->callStack()->asyncCallStack();
if (asyncCallStack)
jsonObj->setAsyncStackTrace(asyncCallStack->buildInspectorObject());
}

Powered by Google App Engine
This is Rietveld 408576698