third_party/WebKit/Source/core/inspector/InspectorBaseAgent.cpp - Issue 1601283003: DevTools: deoilpanize inspector/v8 and related classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorBaseAgent.cpp

Issue 1601283003: DevTools: deoilpanize inspector/v8 and related classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h ('k') | third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorBaseAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorBaseAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorBaseAgent.cpp

index 7b312a4494291da1eeb07e982c807c4ed4550f8c..77789b4d4d061dcc28b05d7c88f48ecc2813d5e8 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorBaseAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorBaseAgent.cpp

@@ -42,15 +42,11 @@ InspectorAgent::InspectorAgent(const String& name)

InspectorAgent::~InspectorAgent()

{

-#if ENABLE(OILPAN)

- m_state = nullptr;

-#endif

}

DEFINE_TRACE(InspectorAgent)

{

visitor->trace(m_instrumentingAgents);

- visitor->trace(m_state);

}

void InspectorAgent::appended(InstrumentingAgents* instrumentingAgents, InspectorState* inspectorState)

@@ -111,7 +107,6 @@ void InspectorAgentRegistry::flushPendingProtocolNotifications()

DEFINE_TRACE(InspectorAgentRegistry)

{

visitor->trace(m_instrumentingAgents);

- visitor->trace(m_inspectorState);

#if ENABLE(OILPAN)

visitor->trace(m_agents);

#endif