third_party/WebKit/Source/core/frame/ConsoleBase.cpp - Issue 1601283003: DevTools: deoilpanize inspector/v8 and related classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/ConsoleBase.cpp

Issue 1601283003: DevTools: deoilpanize inspector/v8 and related classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/frame/ConsoleBase.cpp

diff --git a/third_party/WebKit/Source/core/frame/ConsoleBase.cpp b/third_party/WebKit/Source/core/frame/ConsoleBase.cpp

index 0fec692afd84345819e54b10baad637aa533915d..6728af7e048541fc57206611346da8c5c781418b 100644

--- a/third_party/WebKit/Source/core/frame/ConsoleBase.cpp

+++ b/third_party/WebKit/Source/core/frame/ConsoleBase.cpp

@@ -103,7 +103,7 @@ void ConsoleBase::assertCondition(ScriptState* scriptState, PassRefPtrWillBeRawP

void ConsoleBase::count(ScriptState* scriptState, PassRefPtrWillBeRawPtr<ScriptArguments> arguments)

{

- RefPtrWillBeRawPtr<ScriptCallStack> callStack(currentScriptCallStackForConsole(1));

+ RefPtr<ScriptCallStack> callStack(currentScriptCallStackForConsole(1));

const ScriptCallFrame& lastCaller = callStack->at(0);

// Follow Firebug's behavior of counting with null and undefined title in

// the same bucket as no argument

« no previous file with comments | « third_party/WebKit/Source/core/dom/ExecutionContext.cpp ('k') | third_party/WebKit/Source/core/frame/DOMWindow.cpp » ('j') | no next file with comments »