third_party/WebKit/Source/core/inspector/ScriptCallFrame.h - Issue 1601283003: DevTools: deoilpanize inspector/v8 and related classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/ScriptCallFrame.h

Issue 1601283003: DevTools: deoilpanize inspector/v8 and related classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/inspector/InspectorRuntimeAgent.h ('K') | « third_party/WebKit/Source/core/inspector/ScriptAsyncCallStack.cpp ('k') | third_party/WebKit/Source/core/inspector/ScriptCallStack.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/ScriptCallFrame.h

diff --git a/third_party/WebKit/Source/core/inspector/ScriptCallFrame.h b/third_party/WebKit/Source/core/inspector/ScriptCallFrame.h

index 69d424f36c486c18573898383a1551a0a805a08a..c3b81504a6a601dc5f280b20f9b81d8da0e4db29 100644

--- a/third_party/WebKit/Source/core/inspector/ScriptCallFrame.h

+++ b/third_party/WebKit/Source/core/inspector/ScriptCallFrame.h

@@ -41,7 +41,6 @@ namespace blink {

class TracedValue;

class ScriptCallFrame {

- DISALLOW_NEW_EXCEPT_PLACEMENT_NEW();

sof 2016/01/20 11:39:50 It wouldn't hurt to keep this; not Oilpan specific

pfeldman 2016/01/20 17:53:28 Done.

public:

ScriptCallFrame();

ScriptCallFrame(const String& functionName, const String& scriptId, const String& scriptName, unsigned lineNumber, unsigned column = 0);