Issue 160126: NNTP: Adds 2 hard coded thumbnails....

Issue 160126: NNTP: Adds 2 hard coded thumbnails.... (Closed)

Created:
11 years, 5 months ago by arv (Not doing code reviews)

Modified:
9 years, 3 months ago

Reviewers:
Glen Murphy

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

, INNTP: Adds 2 hard coded thumbnails. This code needs to be rewritten after beta to handle localized content. BUG=15079 TEST=Start chrome with a new profile. There should be 2 thumbnails on the new tab page. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21608

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Patch Set 10 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+99 lines, -7 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+11 lines, -1 line	0 comments	Download
M	chrome/app/resources/locale_settings.grd	View		1 chunk	+10 lines, -2 lines	0 comments	Download
M	chrome/app/theme/theme_resources.grd	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/dom_ui/new_tab_ui.cc	View	1 2 3 4 5 6 7 8 9	7 chunks	+71 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/new_new_tab.js	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Glen Murphy

LGTM http://codereview.chromium.org/160126/diff/33/1016 File chrome/browser/dom_ui/new_tab_ui.cc (right): http://codereview.chromium.org/160126/diff/33/1016#newcode799 Line 799: const size_t pages_count = NewTabUI::UseOldNewTabPage() ? You ...

11 years, 5 months ago (2009-07-24 23:16:50 UTC) #2

arv (Not doing code reviews)

11 years, 5 months ago (2009-07-24 23:22:42 UTC) #3

FYI, I'm submitting the images in a separate patch to get the try bots happy.

On Fri, Jul 24, 2009 at 16:16, <glen@chromium.org> wrote:
> LGTM
>
>
> http://codereview.chromium.org/160126/diff/33/1016
> File chrome/browser/dom_ui/new_tab_ui.cc (right):
>
> http://codereview.chromium.org/160126/diff/33/1016#newcode799
> Line 799: const size_t pages_count = NewTabUI::UseOldNewTabPage() ?
> You could make this static here, too.
>
> http://codereview.chromium.org/160126/diff/33/1016#newcode877
> Line 877: // TODO(arv): Is there some way to get from the IDR constants
> to the URL?
> AFAIK there is no reverse mapping.
>
> http://codereview.chromium.org/160126
>



-- 
erik

Expand Messages | Collapse Messages