Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1601253003:
Update libwebp to version 0.5.0 (Closed)
DescriptionUpdate libwebp to version 0.5.0
This is the version used by Android.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1601253003
Committed: https://skia.googlesource.com/skia/+/0ac723b6f4502d96a0fb5c2ad6a69994afe0347c
Patch Set 1 #Patch Set 2 : Build rescaler_neon.c for iOS build #Patch Set 3 : Only build _neon files in neon target #Messages
Total messages: 22 (13 generated)
Description was changed from ========== Update libwebp to version 0.5.0 This is the version used by Android. ========== to ========== Update libwebp to version 0.5.0 This is the version used by Android. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
scroggo@google.com changed reviewers: + msarett@google.com
The CQ bit was checked by scroggo@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1601253003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1601253003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Mac10.9-Clang-Arm7-Debug-iOS-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.9-Clang-...)
lgtm if you can get past the commit bots
The CQ bit was checked by scroggo@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from msarett@google.com Link to the patchset: https://codereview.chromium.org/1601253003/#ps20001 (title: "Build rescaler_neon.c for iOS build")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1601253003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1601253003/20001
Message was sent while issue was closed.
Description was changed from ========== Update libwebp to version 0.5.0 This is the version used by Android. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Update libwebp to version 0.5.0 This is the version used by Android. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/fe35455210294c3d9de9d0d9534743acfade523d ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/fe35455210294c3d9de9d0d9534743acfade523d
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1601083004/ by benjaminwagner@google.com. The reason for reverting is: Seems to be causing bots to fail: https://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Ar... https://build.chromium.org/p/client.skia.android/builders/Perf-Android-GCC-Ne... https://build.chromium.org/p/client.skia.android/builders/Perf-Android-GCC-Ne... https://build.chromium.org/p/client.skia.fyi/builders/Perf-Android-GCC-Nexus5... https://build.chromium.org/p/client.skia.android/builders/Test-Android-GCC-Ne... https://build.chromium.org/p/client.skia.android/builders/Test-Android-GCC-Ne... https://build.chromium.org/p/client.skia.android/builders/Test-Android-GCC-Ne... https://build.chromium.org/p/client.skia.android/builders/Test-Android-GCC-Ne... https://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Ar... .
Message was sent while issue was closed.
Patchset #3 (id:40001) has been deleted
Message was sent while issue was closed.
Description was changed from ========== Update libwebp to version 0.5.0 This is the version used by Android. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/fe35455210294c3d9de9d0d9534743acfade523d ========== to ========== Update libwebp to version 0.5.0 This is the version used by Android. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/fe35455210294c3d9de9d0d9534743acfade523d ==========
Description was changed from ========== Update libwebp to version 0.5.0 This is the version used by Android. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/fe35455210294c3d9de9d0d9534743acfade523d ========== to ========== Update libwebp to version 0.5.0 This is the version used by Android. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was checked by scroggo@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from msarett@google.com Link to the patchset: https://codereview.chromium.org/1601253003/#ps60001 (title: "Only build _neon files in neon target")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1601253003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1601253003/60001
Message was sent while issue was closed.
Description was changed from ========== Update libwebp to version 0.5.0 This is the version used by Android. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Update libwebp to version 0.5.0 This is the version used by Android. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/0ac723b6f4502d96a0fb5c2ad6a69994afe0347c ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as https://skia.googlesource.com/skia/+/0ac723b6f4502d96a0fb5c2ad6a69994afe0347c |
