Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5107)

Unified Diff: chrome/browser/browser.cc

Issue 160122: Make downloads not prevent tabs from closing.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browser.cc
===================================================================
--- chrome/browser/browser.cc (revision 21534)
+++ chrome/browser/browser.cc (working copy)
@@ -1557,7 +1557,7 @@
// them. Once they have fired, we'll get a message back saying whether
// to proceed closing the page or not, which sends us back to this method
// with the HasUnloadListener bit cleared.
- contents->render_view_host()->FirePageBeforeUnload();
+ contents->render_view_host()->FirePageBeforeUnload(false);
return true;
}
return false;
@@ -2470,7 +2470,7 @@
// Null check render_view_host here as this gets called on a PostTask and
// the tab's render_view_host may have been nulled out.
if (tab->render_view_host()) {
- tab->render_view_host()->FirePageBeforeUnload();
+ tab->render_view_host()->FirePageBeforeUnload(false);
} else {
ClearUnloadState(tab);
}
« no previous file with comments | « no previous file | chrome/browser/renderer_host/render_view_host.h » ('j') | chrome/browser/renderer_host/render_view_host.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698