Issue 1601183003: SignalInfo must store fd_ as an intptr_t not an int.

Issue 1601183003: SignalInfo must store fd_ as an intptr_t not an int. (Closed)

Created:
4 years, 11 months ago by Vyacheslav Egorov (Google)

Modified:
4 years, 11 months ago

Reviewers:
Florian Schneider, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

SignalInfo must store fd_ as an intptr_t not an int. On Windows we use this field to store a pointer to FileHandle object. Type of SignalInfo::signal_ is changed to intptr_t too for consistency. BUG=http://dartbug.com/25345 R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/89121bf530b1b25686597f5b1e03c16de9ae3023

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	runtime/bin/process.h	View		2 chunks	+5 lines, -5 lines	0 comments	Download

Total messages: 6 (3 generated)

Vyacheslav Egorov (Google)

4 years, 11 months ago (2016-01-19 20:51:21 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
89121bf530b1b25686597f5b1e03c16de9ae3023 (presubmit successful).