Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 1601153002: [Interpreter] Ensure that block breaks are within the correct context scope. (Closed)

Created:
4 years, 11 months ago by rmcilroy
Modified:
4 years, 11 months ago
Reviewers:
oth
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Ensure that block breaks are within the correct context scope. Fixes a bug where the context would be popped before labeled block break target location. BUG=v8:4280 LOG=N Committed: https://crrev.com/603acc3f49e2190e8ec253ea259cb94da6ad30d7 Cr-Commit-Position: refs/heads/master@{#33388}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -17 lines) Patch
M src/interpreter/bytecode-generator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +16 lines, -16 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 2 chunks +35 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1601153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1601153002/1
4 years, 11 months ago (2016-01-19 12:50:20 UTC) #2
rmcilroy
Orion, please take a look, thanks.
4 years, 11 months ago (2016-01-19 12:50:30 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-19 13:12:51 UTC) #6
oth
LGTM.
4 years, 11 months ago (2016-01-19 15:45:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1601153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1601153002/1
4 years, 11 months ago (2016-01-19 15:48:50 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-19 15:51:07 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-19 15:51:23 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/603acc3f49e2190e8ec253ea259cb94da6ad30d7
Cr-Commit-Position: refs/heads/master@{#33388}

Powered by Google App Engine
This is Rietveld 408576698