Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1601103010: Add vdlr{s,d} to the integrated ARM assembler. (Closed)

Created:
4 years, 11 months ago by Karl
Modified:
4 years, 11 months ago
Reviewers:
Jim Stichnoth, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add missing file. #

Total comments: 3

Patch Set 3 : Fix remaining issues. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -6 lines) Patch
M src/DartARM32/assembler_arm.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/DartARM32/assembler_arm.cc View 1 4 chunks +6 lines, -4 lines 0 comments Download
M src/IceAssemblerARM32.h View 1 chunk +18 lines, -0 lines 0 comments Download
M src/IceAssemblerARM32.cpp View 1 2 2 chunks +46 lines, -1 line 0 comments Download
M src/IceInstARM32.cpp View 1 chunk +6 lines, -1 line 0 comments Download
A tests_lit/assembler/arm32/vldr.ll View 1 2 1 chunk +60 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Karl
4 years, 11 months ago (2016-01-19 21:34:14 UTC) #5
Jim Stichnoth
lgtm https://codereview.chromium.org/1601103010/diff/20001/tests_lit/assembler/arm32/vldr.ll File tests_lit/assembler/arm32/vldr.ll (right): https://codereview.chromium.org/1601103010/diff/20001/tests_lit/assembler/arm32/vldr.ll#newcode38 tests_lit/assembler/arm32/vldr.ll:38: %vaddr = bitcast [4 x i8]* @floatVal to ...
4 years, 11 months ago (2016-01-19 23:48:25 UTC) #6
Karl
Committed patchset #3 (id:40001) manually as e1d71380ff9de84268c3865a89d16519385cef4a (tree was closed).
4 years, 11 months ago (2016-01-21 17:47:22 UTC) #8
Karl
4 years, 11 months ago (2016-01-21 17:47:36 UTC) #9
Message was sent while issue was closed.
https://codereview.chromium.org/1601103010/diff/20001/src/IceAssemblerARM32.cpp
File src/IceAssemblerARM32.cpp (right):

https://codereview.chromium.org/1601103010/diff/20001/src/IceAssemblerARM32.c...
src/IceAssemblerARM32.cpp:2198: // cccc1101ud01nnnndddd1010iiiiiiii.
Delete this line (don't duplicate pattern).

Done.

https://codereview.chromium.org/1601103010/diff/20001/tests_lit/assembler/arm...
File tests_lit/assembler/arm32/vldr.ll (right):

https://codereview.chromium.org/1601103010/diff/20001/tests_lit/assembler/arm...
tests_lit/assembler/arm32/vldr.ll:38: %vaddr = bitcast [4 x i8]* @floatVal to
float*
On 2016/01/19 23:48:25, stichnot wrote:
> If you want to start with even simpler bitcode, you could probably just 'reg
> float 1.0' or with some other nonzero constant.

Done.

Powered by Google App Engine
This is Rietveld 408576698