Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 160110: Update WebKit from 46288 to 46363.... (Closed)

Created:
11 years, 5 months ago by darin (slow to review)
Modified:
9 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews_googlegroups.com, darin (slow to review)
Visibility:
Public.

Description

Update WebKit from 46288 to 46363. This appears to fix http://crbug.com/17326 since the last test that was failing in that set is now passing. LayoutTests/editing/selection/move-begin-end.html is also passing now. I'm not sure which WebKit patch to attribute that to. http://trac.webkit.org/changeset/46363 caused a boat-load of tests to need to be re-baselined, but that is expected and probably a temporary condition. Stephen wanted to revert his WebCore change to see if it would resolve the reliability test failure. Otherwise, it looks like we picked up some media related crashers :-( TBR=pkasting BUG=17326 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21554

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -10 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/layout_tests/test_expectations.txt View 3 chunks +120 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
darin (slow to review)
11 years, 5 months ago (2009-07-24 18:40:19 UTC) #1
Peter Kasting
11 years, 5 months ago (2009-07-24 18:42:49 UTC) #2
Rubber-stamp LGTM

Powered by Google App Engine
This is Rietveld 408576698