Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 1601063002: Removes ImeController::UsingFrenchInputMethod and thus ImeControlDelegate::RemapAccelerator. (Closed)

Created:
4 years, 11 months ago by Shu Chen
Modified:
4 years, 11 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removes ImeController::UsingFrenchInputMethod and thus ImeControlDelegate::RemapAccelerator. RemapAccelerator was introduced by cl https://chromiumcodereview.appspot.com/10452042 which was to solve the issue that FR keyboard issues the number keys with key codes other than VKEY_0 - VKEY_9. That issue has been fixed in Ozone now, so FR keyboard can issue VKEY_0-VKEY_9 for number keys correctly. Therefore, RemapAccelerator is useless. BUG=572219 TEST=No compile error. Issue 129017 doesn't repro. Committed: https://crrev.com/44384461e5c09949119390beaa045b68c88681a1 Cr-Commit-Position: refs/heads/master@{#370239}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -163 lines) Patch
M ash/accelerators/accelerator_controller.cc View 3 chunks +4 lines, -12 lines 0 comments Download
M ash/accelerators/accelerator_controller_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/ime_control_delegate.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/ash/ime_controller_chromeos.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/ime_controller_chromeos.cc View 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/browser/ui/ash/ime_controller_chromeos_unittest.cc View 1 chunk +0 lines, -102 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
Shu Chen
Oshima, can you please review this? Thanks
4 years, 11 months ago (2016-01-19 03:02:47 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1601063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1601063002/1
4 years, 11 months ago (2016-01-19 03:02:58 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-19 03:40:48 UTC) #9
oshima
lgtm
4 years, 11 months ago (2016-01-19 18:22:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1601063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1601063002/1
4 years, 11 months ago (2016-01-20 00:27:11 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-20 00:38:46 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 00:39:36 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/44384461e5c09949119390beaa045b68c88681a1
Cr-Commit-Position: refs/heads/master@{#370239}

Powered by Google App Engine
This is Rietveld 408576698