Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1601023005: Remove a bit more dead code after array spread desugaring (Closed)

Created:
4 years, 11 months ago by adamk
Modified:
4 years, 11 months ago
Reviewers:
nickie
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove a bit more dead code after array spread desugaring Committed: https://crrev.com/f1cd428d0103c2e487a681051d15ae77ab7003dd Cr-Commit-Position: refs/heads/master@{#33446}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix is_simple #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M src/ast/ast.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
adamk
4 years, 11 months ago (2016-01-20 19:26:20 UTC) #2
nickie
Other than my comment, LGTM. https://codereview.chromium.org/1601023005/diff/1/src/ast/ast.cc File src/ast/ast.cc (left): https://codereview.chromium.org/1601023005/diff/1/src/ast/ast.cc#oldcode511 src/ast/ast.cc:511: bool is_simple = (first_spread_index_ ...
4 years, 11 months ago (2016-01-21 09:11:41 UTC) #3
adamk
https://codereview.chromium.org/1601023005/diff/1/src/ast/ast.cc File src/ast/ast.cc (left): https://codereview.chromium.org/1601023005/diff/1/src/ast/ast.cc#oldcode511 src/ast/ast.cc:511: bool is_simple = (first_spread_index_ < 0); On 2016/01/21 09:11:41, ...
4 years, 11 months ago (2016-01-21 18:52:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1601023005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1601023005/20001
4 years, 11 months ago (2016-01-21 18:52:18 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-21 19:44:50 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 19:45:20 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f1cd428d0103c2e487a681051d15ae77ab7003dd
Cr-Commit-Position: refs/heads/master@{#33446}

Powered by Google App Engine
This is Rietveld 408576698