Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 1600973003: dart2js cps: Handle unsafe .length calls in bounds check elimination. (Closed)

Created:
4 years, 11 months ago by asgerf
Modified:
4 years, 11 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Handle unsafe .length calls in bounds check elimination. BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/07f43b548043dc274d5c30d61aa30c3b50c93dfc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M pkg/compiler/lib/src/cps_ir/bounds_checker.dart View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
asgerf
4 years, 11 months ago (2016-01-19 19:27:58 UTC) #2
Siggi Cherem (dart-lang)
lgtm
4 years, 11 months ago (2016-01-19 19:30:16 UTC) #3
asgerf
4 years, 11 months ago (2016-01-19 22:37:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
07f43b548043dc274d5c30d61aa30c3b50c93dfc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698