Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 1600953003: Move find-in-page code from RenderView to RenderFrame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments by nasko@, git cl format. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index ccadfb2dd064e1bbb6b946cd04e94266c938a7cf..6a32a012138785f889884a9d23b80fb9dded7648 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -661,7 +661,7 @@ bool WebContentsImpl::OnMessageReceived(RenderViewHost* render_view_host,
OnUnregisterProtocolHandler)
IPC_MESSAGE_HANDLER(FrameHostMsg_UpdatePageImportanceSignals,
OnUpdatePageImportanceSignals)
- IPC_MESSAGE_HANDLER(ViewHostMsg_Find_Reply, OnFindReply)
+ IPC_MESSAGE_HANDLER(FrameHostMsg_Find_Reply, OnFindReply)
IPC_MESSAGE_HANDLER(ViewHostMsg_AppCacheAccessed, OnAppCacheAccessed)
IPC_MESSAGE_HANDLER(ViewHostMsg_WebUISend, OnWebUISend)
#if defined(ENABLE_PLUGINS)
@@ -685,7 +685,7 @@ bool WebContentsImpl::OnMessageReceived(RenderViewHost* render_view_host,
IPC_MESSAGE_HANDLER(ViewHostMsg_MoveValidationMessage,
OnMoveValidationMessage)
#if defined(OS_ANDROID) && !defined(USE_AURA)
- IPC_MESSAGE_HANDLER(ViewHostMsg_FindMatchRects_Reply,
+ IPC_MESSAGE_HANDLER(FrameHostMsg_FindMatchRects_Reply,
OnFindMatchRectsReply)
IPC_MESSAGE_HANDLER(ViewHostMsg_OpenDateTimeDialog,
OnOpenDateTimeDialog)
@@ -2860,7 +2860,8 @@ void WebContentsImpl::Find(int request_id,
browser_plugin_embedder_->Find(request_id, search_text, options)) {
return;
}
- Send(new ViewMsg_Find(GetRoutingID(), request_id, search_text, options));
+ GetMainFrame()->Send(new FrameMsg_Find(GetMainFrame()->GetRoutingID(),
+ request_id, search_text, options));
}
void WebContentsImpl::StopFinding(StopFindAction action) {
@@ -2869,7 +2870,8 @@ void WebContentsImpl::StopFinding(StopFindAction action) {
browser_plugin_embedder_->StopFinding(action)) {
return;
}
- Send(new ViewMsg_StopFinding(GetRoutingID(), action));
+ GetMainFrame()->Send(
+ new FrameMsg_StopFinding(GetMainFrame()->GetRoutingID(), action));
}
void WebContentsImpl::InsertCSS(const std::string& css) {

Powered by Google App Engine
This is Rietveld 408576698