Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 160093006: Fix find bar positioning for hosted app windows (Closed)

Created:
6 years, 10 months ago by pkotwicz
Modified:
6 years, 10 months ago
Reviewers:
James Cook
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Make the TopContainerView always fully overlap the window header because we use the TopContainerView bounds in computing the find bar's position BUG=341636 TEST=BrowserViewHostedAppTest.Layout Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251422

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -30 lines) Patch
M chrome/browser/ui/views/frame/browser_view_layout.cc View 1 1 chunk +24 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view_unittest.cc View 1 2 2 chunks +49 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/top_container_view.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/top_container_view.cc View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
pkotwicz
James can you please take a look? https://codereview.chromium.org/160093006/diff/40001/chrome/browser/ui/views/frame/browser_view_layout.cc File chrome/browser/ui/views/frame/browser_view_layout.cc (right): https://codereview.chromium.org/160093006/diff/40001/chrome/browser/ui/views/frame/browser_view_layout.cc#newcode546 chrome/browser/ui/views/frame/browser_view_layout.cc:546: height = ...
6 years, 10 months ago (2014-02-12 01:43:35 UTC) #1
James Cook
LGTM
6 years, 10 months ago (2014-02-12 20:27:38 UTC) #2
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 10 months ago (2014-02-12 22:30:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/160093006/40001
6 years, 10 months ago (2014-02-12 22:35:31 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 03:14:25 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=263198
6 years, 10 months ago (2014-02-13 03:14:26 UTC) #6
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 10 months ago (2014-02-13 15:43:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/160093006/380001
6 years, 10 months ago (2014-02-13 15:45:00 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 16:22:52 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, base_unittests, browser_tests, cacheinvalidation_unittests, ...
6 years, 10 months ago (2014-02-13 16:22:53 UTC) #10
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 10 months ago (2014-02-13 19:23:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/160093006/380001
6 years, 10 months ago (2014-02-13 19:24:20 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/160093006/380001
6 years, 10 months ago (2014-02-13 20:04:11 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 01:02:41 UTC) #14
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=263926
6 years, 10 months ago (2014-02-14 01:02:41 UTC) #15
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 10 months ago (2014-02-14 15:09:46 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/160093006/840001
6 years, 10 months ago (2014-02-14 15:11:58 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 16:31:47 UTC) #18
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=264315
6 years, 10 months ago (2014-02-14 16:31:47 UTC) #19
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 10 months ago (2014-02-14 20:11:21 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/160093006/840001
6 years, 10 months ago (2014-02-14 20:14:27 UTC) #21
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 21:19:04 UTC) #22
Message was sent while issue was closed. 
Change committed as 251422

Powered by Google App Engine
This is Rietveld 408576698