Issue 160093: Let theme values that previous had to be real be specified as ints....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 160093: Let theme values that previous had to be real be specified as ints.... (Closed)

Created:
11 years, 5 months ago by Glen Murphy

Modified:
9 years, 5 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews_googlegroups.com, Erik does not do reviews, Ben Goodger (Google)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Let theme values that previous had to be real be specified as ints. Also bonus update to background_tab_text naming. BUG=16892 TEST=Create and install a theme with integer values for ntp_section opacity or tint values. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21519

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -13 lines)			Patch
	M	chrome/browser/browser_theme_provider.cc	View	1	3 chunks	+17 lines, -8 lines	0 comments	Download
	M	chrome/common/extensions/extension.cc	View		2 chunks	+8 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

11 years, 5 months ago (2009-07-24 07:26:24 UTC) #2

lgtm with nits

http://codereview.chromium.org/160093/diff/1/2
File chrome/browser/browser_theme_provider.cc (right):

http://codereview.chromium.org/160093/diff/1/2#newcode567
Line 567: int value;
Initialize this guy.

http://codereview.chromium.org/160093/diff/1/2#newcode569
Line 569: tint_list->GetInteger(0, &value);
Also, I realize the manifest validation should have ensured there are values
here, but I think it is worth being defensive:

if (tint_list->GetInteger(...)) {
  hsl.x = ...
}

Otherwise, if GetInteger() fails, you are setting the hsl component to whatever
happened to be in value before.

Expand Messages | Collapse Messages