Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 1600923002: [runtime] Stop cloning AccessorInfo, just rely on PropertyAttributes for readonly. (Closed)

Created:
4 years, 11 months ago by Toon Verwaest
Modified:
4 years, 11 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Stop cloning AccessorInfo, just rely on PropertyAttributes for readonly. The old mechanism was a left-over from a previous time where the runtime would rely on the presence or absence of the setter to figure out whether or not the property is mutable. This is unnecessary by now. Committed: https://crrev.com/90952d768b8d64a0d8b3ee60365c2ef16c57ec5d Cr-Commit-Position: refs/heads/master@{#33377}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -35 lines) Patch
M src/accessors.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/accessors.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/objects.cc View 2 chunks +1 line, -16 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 11 months ago (2016-01-18 17:54:39 UTC) #2
Igor Sheludko
lgtm
4 years, 11 months ago (2016-01-18 18:11:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1600923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1600923002/1
4 years, 11 months ago (2016-01-18 19:24:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-18 19:59:33 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-18 20:00:11 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/90952d768b8d64a0d8b3ee60365c2ef16c57ec5d
Cr-Commit-Position: refs/heads/master@{#33377}

Powered by Google App Engine
This is Rietveld 408576698