Issue 160090: Workaround to get Linux/ChromeOS building - it appears to not be picking up f...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 160090: Workaround to get Linux/ChromeOS building - it appears to not be picking up f... (Closed)

Created:
11 years, 5 months ago by Glen Murphy

Modified:
9 years, 5 months ago

Reviewers:
Nicolas Sylvain, Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Workaround to get Linux/ChromeOS building - it appears to not be picking up file adds to app/theme/google_chrome (product_logo_white.png was added, but the ChromeOS builder can't find it). We need to figure this out tomorrow for beta cutoff. TBR=ben,brettw,nsylvain BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21511

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/app/theme/theme_resources.grd	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

11 years, 5 months ago (2009-07-24 05:26:08 UTC) #2

OK

On Thu, Jul 23, 2009 at 10:22 PM, <glen@chromium.org> wrote:
> Reviewers: Nicolas Sylvain, Ben Goodger,
>
> Description:
> Workaround to get Linux/ChromeOS building - it appears to not be picking
> up file adds to app/theme/google_chrome (product_logo_white.png was
> added, but the ChromeOS builder can't find it). We need to figure this
> out tomorrow for beta cutoff.
>
> TBR=3Dben,brettw,nsylvain
> BUG=3Dnone
> TEST=3Dnone
>
>
> Please review this at http://codereview.chromium.org/160090
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
> =A0M =A0 =A0 chrome/app/theme/theme_resources.grd
>
>
> Index: chrome/app/theme/theme_resources.grd
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- chrome/app/theme/theme_resources.grd =A0 =A0 =A0 =A0(revision 21510)
> +++ chrome/app/theme/theme_resources.grd =A0 =A0 =A0 =A0(working copy)
> @@ -323,7 +323,7 @@
> =A0 =A0 =A0 =A0 <include name=3D"IDR_ABOUT_BACKGROUND_RTL"
> file=3D"chromium/about_background_rtl.png" type=3D"BINDATA" />
> =A0 =A0 =A0 =A0 <include name=3D"IDR_ABOUT_BACKGROUND_COLOR"
> file=3D"chromium/about_background_color.png" type=3D"BINDATA" />
> =A0 =A0 =A0 =A0 <include name=3D"IDR_PRODUCT_LOGO" file=3D"chromium/produ=
ct_logo.png"
> type=3D"BINDATA" />
> - =A0 =A0 =A0 =A0<include name=3D"IDR_PRODUCT_LOGO_WHITE"
> file=3D"chromium/product_logo_white.png" type=3D"BINDATA" />
> + =A0 =A0 =A0 =A0<include name=3D"IDR_PRODUCT_LOGO_WHITE"
> file=3D"chromium/product_logo.png" type=3D"BINDATA" />
> =A0 =A0 =A0 =A0 <include name=3D"IDR_PRODUCT_LOGO_16"
> file=3D"chromium/product_logo_16.png" type=3D"BINDATA" />
> =A0 =A0 =A0 =A0 <include name=3D"IDR_WIZARD_ICON" file=3D"chromium/wizard=
_icon.png"
> type=3D"BINDATA" />
> =A0 =A0 =A0 =A0 <include name=3D"IDR_WIZARD_ICON_RTL"
> file=3D"chromium/wizard_icon_rtl.png" type=3D"BINDATA" />
>
>
>

Expand Messages | Collapse Messages