Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 1600873002: [formatting] Remove the formatting requirement for 2 empty lines between declarations. (Closed)

Created:
4 years, 11 months ago by titzer
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[formatting] Remove the formatting requirement for 2 empty lines between declarations. R=mstarzinger@chromium.org,rossberg@chromium.org,bmeurer@chromium.org,hpayer@chromium.org,jochen@chromium.org BUG= Committed: https://crrev.com/28d3cba2431d617c17d8a7f83f07efac94837358 Cr-Commit-Position: refs/heads/master@{#33485}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -25 lines) Patch
M .clang-format View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/presubmit.py View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
rossberg
LGTM, but let's hear a few more opinions
4 years, 11 months ago (2016-01-18 12:11:27 UTC) #1
jochen (gone - plz use gerrit)
lgtm
4 years, 11 months ago (2016-01-18 12:12:50 UTC) #2
Michael Starzinger
LGTM from my end. But I agree with Andreas, lets give it some more bake ...
4 years, 11 months ago (2016-01-18 12:22:50 UTC) #3
titzer
On 2016/01/18 12:22:50, Michael Starzinger wrote: > LGTM from my end. But I agree with ...
4 years, 11 months ago (2016-01-18 12:24:18 UTC) #4
Hannes Payer (out of office)
LGTM
4 years, 11 months ago (2016-01-20 12:15:57 UTC) #5
jochen (gone - plz use gerrit)
did this bake long enough?
4 years, 11 months ago (2016-01-25 08:54:15 UTC) #6
titzer
On 2016/01/25 08:54:15, jochen wrote: > did this bake long enough? Yeah, I think we ...
4 years, 11 months ago (2016-01-25 09:02:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1600873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1600873002/20001
4 years, 11 months ago (2016-01-25 09:35:57 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-25 09:50:05 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 09:50:23 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/28d3cba2431d617c17d8a7f83f07efac94837358
Cr-Commit-Position: refs/heads/master@{#33485}

Powered by Google App Engine
This is Rietveld 408576698