Split cocoa_event_utils in two parts.

Split cocoa_event_utils in two parts.

One is cocoa_events_utils which is moved to ui/events/cocoa and contains
only events related code. The other is cocoa_base_utils which uses code
from ui/base so needs to stay in ui/base/cocoa.

BUG=299841
TEST=ui_unittests, events_unittests
R=sadrul@chromium.org
TBR=ben

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252579

[sadrul, 2014-02-13 04:30:44]

https://codereview.chromium.org/160083003/diff/30001/ui/events/cocoa/cocoa_ev...
File ui/events/cocoa/cocoa_event_utils.h (right):

https://codereview.chromium.org/160083003/diff/30001/ui/events/cocoa/cocoa_ev...
ui/events/cocoa/cocoa_event_utils.h:1: // Copyright 2013 The Chromium Authors.
All rights reserved.
2014 (do we not have a presubmit script for this?)

https://codereview.chromium.org/160083003/diff/30001/ui/events/cocoa/cocoa_ev...
ui/events/cocoa/cocoa_event_utils.h:15: EVENTS_EXPORT int
EventFlagsFromNSEvent(NSEvent* event);
Can the users of this function be using the EventFlagsFromNative() version
instead (since base::NativeEvent == NSEvent)?

https://codereview.chromium.org/160083003/diff/30001/ui/ui.gyp
File ui/ui.gyp (right):

https://codereview.chromium.org/160083003/diff/30001/ui/ui.gyp#newcode88
ui/ui.gyp:88: 'base/cocoa/controls/blue_label_button.h',
Do you need to add the cocoa_base_utils files here?

[tfarina, 2014-02-15 00:34:26]

https://codereview.chromium.org/160083003/diff/30001/ui/events/cocoa/cocoa_ev...
File ui/events/cocoa/cocoa_event_utils.h (right):

https://codereview.chromium.org/160083003/diff/30001/ui/events/cocoa/cocoa_ev...
ui/events/cocoa/cocoa_event_utils.h:1: // Copyright 2013 The Chromium Authors.
All rights reserved.
On 2014/02/13 04:30:44, sadrul wrote:
> 2014 (do we not have a presubmit script for this?)

Done.

https://codereview.chromium.org/160083003/diff/30001/ui/events/cocoa/cocoa_ev...
ui/events/cocoa/cocoa_event_utils.h:15: EVENTS_EXPORT int
EventFlagsFromNSEvent(NSEvent* event);
On 2014/02/13 04:30:44, sadrul wrote:
> Can the users of this function be using the EventFlagsFromNative() version
> instead (since base::NativeEvent == NSEvent)?

Done.

https://codereview.chromium.org/160083003/diff/30001/ui/ui.gyp
File ui/ui.gyp (right):

https://codereview.chromium.org/160083003/diff/30001/ui/ui.gyp#newcode88
ui/ui.gyp:88: 'base/cocoa/controls/blue_label_button.h',
On 2014/02/13 04:30:44, sadrul wrote:
> Do you need to add the cocoa_base_utils files here?

Done.

[sadrul, 2014-02-18 19:31:38]

Looks good in general at its current state, but the mac bots seem to be failing
on compile.

https://codereview.chromium.org/160083003/diff/340001/ui/events/events_stub.cc
File ui/events/events_stub.cc (left):

https://codereview.chromium.org/160083003/diff/340001/ui/events/events_stub.c...
ui/events/events_stub.cc:29: 
Why this change?

[tfarina, 2014-02-18 19:42:59]

I'll fix the other failure later tonight:

../../chrome/browser/ui/cocoa/accelerators_cocoa.mm:13:9: fatal error:
'ui/base/cocoa/cocoa_event_utils.h' file not found

this should be ui/events/cocoa

I forgot to update this after the rebase.

https://codereview.chromium.org/160083003/diff/340001/ui/events/events_stub.cc
File ui/events/events_stub.cc (left):

https://codereview.chromium.org/160083003/diff/340001/ui/events/events_stub.c...
ui/events/events_stub.cc:29: 
On 2014/02/18 19:31:39, sadrul wrote:
> Why this change?

this was one attempt to fix the compile failure from patch set 7.

[tfarina, 2014-02-19 03:00:31]

On 2014/02/18 19:31:38, sadrul wrote:
> Looks good in general at its current state, but the mac bots seem to be
failing
> on compile.
> 
Done.

[sadrul, 2014-02-19 18:39:17]

[There still seems to be build failures on mac]

https://codereview.chromium.org/160083003/diff/430001/ui/events/events_stub.cc
File ui/events/events_stub.cc (left):

https://codereview.chromium.org/160083003/diff/430001/ui/events/events_stub.c...
ui/events/events_stub.cc:28: }
Wouldn't this be useful/necessary for other platforms that use events_stub (are
there any such platforms)?

[tfarina, 2014-02-19 19:27:11]

On 2014/02/19 18:39:17, sadrul wrote:
> [There still seems to be build failures on mac]
> 
I hope you can understand my side (and ignore them), as I don't have a Mac to
build locally.

> https://codereview.chromium.org/160083003/diff/430001/ui/events/events_stub.cc
> File ui/events/events_stub.cc (left):
> 
>
https://codereview.chromium.org/160083003/diff/430001/ui/events/events_stub.c...
> ui/events/events_stub.cc:28: }
> Wouldn't this be useful/necessary for other platforms that use events_stub
(are
> there any such platforms)?
Is there other way to fix the redefinition failure from patch set 7?

[sadrul, 2014-02-20 14:55:58]

LGTM

https://codereview.chromium.org/160083003/diff/520002/ui/events/events_stub.cc
File ui/events/events_stub.cc (left):

https://codereview.chromium.org/160083003/diff/520002/ui/events/events_stub.c...
ui/events/events_stub.cc:25: int EventFlagsFromNative(const base::NativeEvent&
native_event) {
Perhaps wrap this inside a !defined(OS_MACOSX)?

[tfarina, 2014-02-21 02:18:07]

https://codereview.chromium.org/160083003/diff/520002/ui/events/events_stub.cc
File ui/events/events_stub.cc (left):

https://codereview.chromium.org/160083003/diff/520002/ui/events/events_stub.c...
ui/events/events_stub.cc:25: int EventFlagsFromNative(const base::NativeEvent&
native_event) {
On 2014/02/20 14:55:58, sadrul wrote:
> Perhaps wrap this inside a !defined(OS_MACOSX)?

Done.

[tfarina, 2014-02-21 02:18:39]

TBRing Ben for the rest!

[tfarina, 2014-02-21 02:18:45]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-02-21 02:19:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/160083003/630001

[commit-bot: I haz the power, 2014-02-21 02:45:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-21 02:45:44]

Retried try job too often on linux_rel for step(s) telemetry_perf_unittests,
telemetry_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[tfarina, 2014-02-21 13:04:22]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-02-21 13:04:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/160083003/630001

[commit-bot: I haz the power, 2014-02-21 16:49:53]

Change committed as 252579